Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4409707imu;
        Sun, 25 Nov 2018 03:09:42 -0800 (PST)
X-Google-Smtp-Source: AFSGD/XGEgRZliMQwvIy6/hkkhhVlRbSz0ca6Qdn0mndpQwuGZNWIuVWhbJ1pDyqftscFw3uAXPa
X-Received: by 2002:a17:902:b118:: with SMTP id q24mr23306792plr.209.1543144182313;
        Sun, 25 Nov 2018 03:09:42 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1543144182; cv=none;
        d=google.com; s=arc-20160816;
        b=fTkXwTDvdk66DMSeyGjLu1C8ud5nhoBx3u3w+OIA4lR0mZPSoXjGbcYgIqycrIpCSw
         Rgwl8diCjNAf43y/A9PlWjg6hsCHicEyXuJkOlOsPYz3nJ6NtYK52X1S5ET+rKSX+SV5
         K/UvkaR4I6mW+4vzHPYSyhVOsHeGf2xXBgf5OAL74gG+BIyFwTj7ZW4zeTNgHJfMo7++
         hNSEIEjDLryjUl4tasOwiCtX1YzZH3HFT3RAQrgMDHlYNJ7ZRmb590KFbJRodHbcW24J
         pnICnCGpgLSaixy3xQR7aZV/NjrMkjTk23nLGzPkWJilCq779NtMk7c1u/LPUq4ICXJJ
         dt1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :user-agent:message-id:in-reply-to:date:references:organization
         :subject:cc:to:from:dkim-signature;
        bh=n0DEOgC5VJU6Xd+bk9PoBYtQyU49tix3igGZic/sEsc=;
        b=OHvVwRmeQjGay3Iu8acvhYZyFSxOG1CzXypih3ah3Vu/wgGCqH3FdZXcic1yNzzj5w
         8mpCNfx6VWEl8lizDkOha3puGuhMlOwklPMVSxI5zAkPVQwHwZs+v1klfUmEmirAAEQB
         lknORx7w9eIctdLlKSX11Yr3HPtiE2wDLkmzq0r8AROuOMPGYHSTjcWWcdhzbADkTTuk
         R+ypoBzqJnH4M4480W7rjE5ufTGKjA3OGv+MQIposViERND0qrlDzNCsWAKvdm2EAJ5J
         WZAW9IbJLTqgPrynCH+edXHdf78ttHwnHzNCIje683jlGMJilp5EsR11slOfiDGOVsEL
         JF6w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@mork.no header.s=b header.b=CXCzduDY;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id k14si16426938pll.346.2018.11.25.03.09.24;
        Sun, 25 Nov 2018 03:09:42 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@mork.no header.s=b header.b=CXCzduDY;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726226AbeKYV67 (ORCPT <rfc822;morganleezd2003@gmail.com>
        + 99 others); Sun, 25 Nov 2018 16:58:59 -0500
Received: from canardo.mork.no ([148.122.252.1]:57975 "EHLO canardo.mork.no"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726131AbeKYV67 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 25 Nov 2018 16:58:59 -0500
Received: from miraculix.mork.no (miraculix.mork.no [IPv6:2001:4641:0:2:7627:374e:db74:e353])
        (authenticated bits=0)
        by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id wAPB7d18028721
        (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
        Sun, 25 Nov 2018 12:07:39 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b;
        t=1543144061; bh=n0DEOgC5VJU6Xd+bk9PoBYtQyU49tix3igGZic/sEsc=;
        h=From:To:Cc:Subject:References:Date:Message-ID:From;
        b=CXCzduDYmwdZy2ybmKbAVRCojuHkjKAwWeUf0h9Pswf09u3KE8krPNxOrBHAttV10
         ddJ3efQtLuqFNKM4iYyiMqeWO7q9EK3JJ7SKmY5e9qvYMoOotN+O7jpYgLcIu7FqHT
         erj09DtdKlnLBYeQocnixzb1h35gI9T3akENyYJU=
Received: from bjorn by miraculix.mork.no with local (Exim 4.89)
        (envelope-from <bjorn@mork.no>)
        id 1gQsGJ-00022n-Hv; Sun, 25 Nov 2018 12:07:39 +0100
From:   =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
To:     Josh Elsasser <jelsasser@appneta.com>
Cc:     intel-wired-lan@lists.osuosl.org,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
Organization: m
References: <20181124205801.67828-1-jelsasser@appneta.com>
Date:   Sun, 25 Nov 2018 12:07:39 +0100
In-Reply-To: <20181124205801.67828-1-jelsasser@appneta.com> (Josh Elsasser's
        message of "Sat, 24 Nov 2018 12:57:33 -0800")
Message-ID: <87efb92z5w.fsf@miraculix.mork.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: clamav-milter 0.100.2 at canardo
X-Virus-Status: Clean
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Josh Elsasser <jelsasser@appneta.com> writes:

> Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")

Not that it matters much I guess, but I think LX SFPs were unsupported
at that time. The LX support appears to have been added under the radar
while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f33367882
("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")


Bj=C3=B8rn