Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4423822imu; Sun, 25 Nov 2018 03:28:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/V7aDeAzU/obBypJQd1MMotPZOHIZI55zCsh7EWsTukkQRJPovKwZhJMORPT74om95Xkafa X-Received: by 2002:a63:f710:: with SMTP id x16mr20811708pgh.322.1543145288711; Sun, 25 Nov 2018 03:28:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543145288; cv=none; d=google.com; s=arc-20160816; b=ncpInJuBvFue3n2Wi7rNI+iix6cY7j5b52s3B42jkGRErvNV3fIYv0pRIA0yV+YZYN Mo9fIPnXtrznOfIFQLDNgjjC1lUTWi+5eLflC68oid3ZPRaDC/7VODEo8lCVrkJBghtx v7erOKzJhVvON/V2+nfGoDR0Ho5RjBvsO1/4AMbysTRTxG60JkuL81nOpxG88Sfeyz+/ rbiQcooUFSyuEd0FKPJK0Hcpf2ndpWjjNhIoVbz+4ybCNIRByktYk7sNLwQ+iRTKsQRn FyPMEpqQpvHMFeFw44t348rB+WWgDcQUGWhbgqkVbmMeL4t3uLozqbNxpb+mJg5ZSFdw 1Uag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QTX5F1P72hjQd1AFqlGIAwaMVuW69avsjASbM/JcCUI=; b=VnhN9xT5LslTJbvsZKGlbTQbTUyqt7ajwhJp+b1jqCXbIPommCnucvzsEEuBwWhbTc qoBhAH5domU8NBUwU43OB9OhlOUouGqGECepj2Q2dV7ZB8EHMU0WAJp3BDKyouIxEpTC kzLHNAnLjxpY3JqxCv6MP8xquA/dsasbfMXD+2Floc2ElLaqMulEqy8/LJaBN9X+MjPX M+3lhJvDdy9mHT5iwt9Jfb1WqmXfiImEMQFk6R4qrqfG1zTwhi2kUzbxapat2oR6m6ly bJ0u+ILv2DKolmwnBTNVOHLopzNFc0xu4qjmWMef1Qqt5AITgfYIIqImBJ8pjqOtysfk eCNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e6DyWwli; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o68si34158233pfo.140.2018.11.25.03.27.54; Sun, 25 Nov 2018 03:28:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e6DyWwli; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726202AbeKYWSO (ORCPT + 99 others); Sun, 25 Nov 2018 17:18:14 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41874 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbeKYWSO (ORCPT ); Sun, 25 Nov 2018 17:18:14 -0500 Received: by mail-pl1-f195.google.com with SMTP id u6so12512142plm.8; Sun, 25 Nov 2018 03:27:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QTX5F1P72hjQd1AFqlGIAwaMVuW69avsjASbM/JcCUI=; b=e6DyWwlixZPSA9qzk/AF+ursJ6/BR4kLzUBwNIo1Kin671y8bietM4KUkl9WCr12de ZURw68WUHNDEMqZCOPKwRTPB1xOQo4YKKUlCTPuZhLSdh7hDvzy+fVvJp7n+xQma/ifA DaMd2Y65Y2veGqdaglIXvlaAM5X0OfSIk2RjlM1qclFfkMIc5bR6WfTWCQWaDOm8PiYX o40v/bQwJg7j8aJHoISP4bPWHX7pXMOOZWwKaH1PXKqFEkxls8gP/nhoi/IEdbGZbo8Q 81tPIln94lO/jZuliivUK/0EAsGQeHF5fYC0EYbcQ3AfT4V4L6+Inp0fJRVk0VM9dmNu NKwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QTX5F1P72hjQd1AFqlGIAwaMVuW69avsjASbM/JcCUI=; b=VMZeGXWj9Oq5IY0CDVdApMmu17Lj8BuqD/iPS9S71/Ux0FEBlRbJerj3kKx2McWJ1J UTMJIt4kdN/jFz064IqTyxVDIRDfG5NvaWV78vU66prNafVH0e+jT4/Qr5fikR1kqD9t Vs/p4mTzKzc60UAvl13p8rRPwd9dFuXvNZNGz4tfxyEg45Ai9y22S4EFo9ahVktru/lN /nQUNlm8TkU6bJKU62kDX3KmO6XwSPfaVr4fuT5ldtW8PO5zdnYeZ8emsVKau0ZIDiQ8 t3CS3biqsaG4Yv15wPRjbEQrRXXt8cymCEon0PQG6LueM3vUngGUEW09tecmbdF9KrFi sdHw== X-Gm-Message-State: AA+aEWbWTFKZ8NLPk9uJ9tLGuFfe19fEyCGsazSZfQupLF1hq5fnfQWh oab4rxlxfCKXYTFskGsHxJk7MqEizTsN5Q== X-Received: by 2002:a17:902:aa0a:: with SMTP id be10mr22716027plb.266.1543145241629; Sun, 25 Nov 2018 03:27:21 -0800 (PST) Received: from nishad ([106.51.27.228]) by smtp.gmail.com with ESMTPSA id m20sm63565243pgb.56.2018.11.25.03.27.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Nov 2018 03:27:21 -0800 (PST) Date: Sun, 25 Nov 2018 16:57:15 +0530 From: Nishad Kamdar To: Greg Kroah-Hartman Cc: Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 05/26] Staging: fbtft: fbtft-device: Switch to the gpio descriptor interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This switches the fbtft-device.c to use GPIO descriptors rather than numerical gpios: Remove gpios from platform device structure. Neither assign statically numbers to gpios in platform device nor allow gpios to be parsed as module parameters. Signed-off-by: Nishad Kamdar --- drivers/staging/fbtft/fbtft-core.c | 87 ------- drivers/staging/fbtft/fbtft.h | 1 - drivers/staging/fbtft/fbtft_device.c | 344 +-------------------------- 3 files changed, 8 insertions(+), 424 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 75ee16074126..904ba7470abf 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -70,92 +70,6 @@ void fbtft_dbg_hex(const struct device *dev, int groupsize, } EXPORT_SYMBOL(fbtft_dbg_hex); -static unsigned long fbtft_request_gpios_match(struct fbtft_par *par, - struct fbtft_gpio *gpio) -{ - int ret; - unsigned int val; - - fbtft_par_dbg(DEBUG_REQUEST_GPIOS_MATCH, par, "%s('%s')\n", - __func__, gpio->name); - - if (strcasecmp(gpio->name, "reset") == 0) { - par->gpio.reset = gpio->gpio; - return GPIOD_OUT_HIGH; - } else if (strcasecmp(gpio->name, "dc") == 0) { - par->gpio.dc = gpio->gpio; - return GPIOD_OUT_LOW; - } else if (strcasecmp(gpio->name, "cs") == 0) { - par->gpio.cs = gpio->gpio; - return GPIOD_OUT_HIGH; - } else if (strcasecmp(gpio->name, "wr") == 0) { - par->gpio.wr = gpio->gpio; - return GPIOD_OUT_HIGH; - } else if (strcasecmp(gpio->name, "rd") == 0) { - par->gpio.rd = gpio->gpio; - return GPIOD_OUT_HIGH; - } else if (strcasecmp(gpio->name, "latch") == 0) { - par->gpio.latch = gpio->gpio; - return GPIOD_OUT_LOW; - } else if (gpio->name[0] == 'd' && gpio->name[1] == 'b') { - ret = kstrtouint(&gpio->name[2], 10, &val); - if (ret == 0 && val < 16) { - par->gpio.db[val] = gpio->gpio; - return GPIOD_OUT_LOW; - } - } else if (strcasecmp(gpio->name, "led") == 0) { - par->gpio.led[0] = gpio->gpio; - return GPIOD_OUT_LOW; - } else if (strcasecmp(gpio->name, "led_") == 0) { - par->gpio.led[0] = gpio->gpio; - return GPIOD_OUT_HIGH; - } - - return FBTFT_GPIO_NO_MATCH; -} - -static int fbtft_request_gpios(struct fbtft_par *par) -{ - struct fbtft_platform_data *pdata = par->pdata; - struct device *dev = par->info->device; - struct fbtft_gpio *gpio; - unsigned long flags; - int ret; - - if (!(pdata && pdata->gpios)) - return 0; - - gpio = pdata->gpios; - while (gpio->name[0]) { - flags = FBTFT_GPIO_NO_MATCH; - /* if driver provides match function, try it first, - * if no match use our own - */ - if (par->fbtftops.request_gpios_match) - flags = par->fbtftops.request_gpios_match(par, gpio); - if (flags == FBTFT_GPIO_NO_MATCH) - flags = fbtft_request_gpios_match(par, gpio); - if (flags != FBTFT_GPIO_NO_MATCH) { - gpio->gpio = devm_gpiod_get(dev, - dev->driver->name, flags); - if (IS_ERR(gpio->gpio)) { - ret = PTR_ERR(gpio->gpio); - dev_err(dev, - "%s: Failed to request %s GPIO:%d\n", - __func__, gpio->name, ret); - return ret; - - } - fbtft_par_dbg(DEBUG_REQUEST_GPIOS, par, - "%s: '%s' GPIO\n", - __func__, gpio->name); - } - gpio++; - } - - return 0; -} - #ifdef CONFIG_OF static int fbtft_request_one_gpio(struct fbtft_par *par, const char *name, int index, @@ -836,7 +750,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, par->fbtftops.reset = fbtft_reset; par->fbtftops.mkdirty = fbtft_mkdirty; par->fbtftops.update_display = fbtft_update_display; - par->fbtftops.request_gpios = fbtft_request_gpios; if (display->backlight) par->fbtftops.register_backlight = fbtft_register_backlight; diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index a9eed11c29b0..7fdd3b0851ef 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging/fbtft/fbtft.h @@ -134,7 +134,6 @@ struct fbtft_display { */ struct fbtft_platform_data { struct fbtft_display display; - struct fbtft_gpio *gpios; unsigned int rotate; bool bgr; unsigned int fps; diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 50e97da993e7..1917712cda90 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -8,7 +8,7 @@ #include #include #include -#include +#include #include #include