Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4757206imu; Sun, 25 Nov 2018 09:35:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/UUtsPMVkrfLCL/+fiRdndEI3Tojgx1ojZaIURcGHc1bysoh4VPoV/SPo+pUEJSvwPsD3CD X-Received: by 2002:a63:e055:: with SMTP id n21mr21833146pgj.397.1543167337235; Sun, 25 Nov 2018 09:35:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543167337; cv=none; d=google.com; s=arc-20160816; b=A9/NYVs+Qk/r7xpA3npYrFfYxflqV+OdnXMaWneWON7+De0TrAG6q//iY91enPnKO5 morphxz1AT4fSp4iSQdg6PbYDDPVJ5Tu5vraCVwt6hh6rjkMk8q10wKO4f+eUIeuBcAL AQZLMWzCon3ift6SscykDC6NbuKGHdRpH6yiqhgoS9LhcEwFCCxUjoNyEsmal/9efuPO L33tDN9mgyGdMdj9cCFem9wl+kopuDl1EYH3zycZPDRPsV9FUUFdXJZT3eofgzFjsagf QZQ8CB7mcEeqPvWWACHF3+t58usIFVwkfGJwzTIwa4A6VmPobwnun5hUFJLwrM5QhiPi rDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=AKe13pGhWayVQ9WNlfWxZ1O1eSHOKOW2rulffx1zW7I=; b=u7Z4UkPgnrCHdHCAesqeyf39fzjlbO0zIuiwsJKs4Yxx/yXVX9kklxMas2+totkrp2 KMCBnk0BJMqBe90Hqhiu9wJMfKGJTa4AbHuXjxahNDDd9checAsSKobubK9Z74bHIKI5 +R3ihvQBNpyeIHPxP6MyndaTEvbCZIWQylsoouwSDMXhYFRttZYpf0F+H3qle8PoxM+X ebpwEDMoXQFblZweXEEBCKLNPtOIUWH2aIaI/2TpXF42AFP9VEUg5uCboaoufZgH35nd A5L49ElnNLMmELFbrZyRfCH+lAMFoUZ55RyX46ECV/jyfiyrscczbOz+8FuguTn0bekY vvYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e35si29787260pgb.548.2018.11.25.09.35.22; Sun, 25 Nov 2018 09:35:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbeKZE0U (ORCPT + 99 others); Sun, 25 Nov 2018 23:26:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbeKZE0U (ORCPT ); Sun, 25 Nov 2018 23:26:20 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D851083F46; Sun, 25 Nov 2018 17:34:46 +0000 (UTC) Received: from [10.36.112.19] (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7868604CD; Sun, 25 Nov 2018 17:34:43 +0000 (UTC) Subject: Re: [PATCH] svm: Add mutex_lock to protect apic_access_page_done on AMD systems To: "joro@8bytes.org" , "Suthikulpanit, Suravee" Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "rkrcmar@redhat.com" , Wei Wang , Amadeusz Juskowiak , Julian Stecklina References: <20181112122255.128953-1-Suravee.Suthikulpanit@amd.com> <20181112133731.lwje2hzibd64cvc3@8bytes.org> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; prefer-encrypt=mutual; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <70cc4362-5a95-d6ec-fccf-4cbe3b03bdc9@redhat.com> Date: Sun, 25 Nov 2018 18:34:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181112133731.lwje2hzibd64cvc3@8bytes.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 25 Nov 2018 17:34:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/18 14:37, joro@8bytes.org wrote: > On Mon, Nov 12, 2018 at 12:23:14PM +0000, Suthikulpanit, Suravee wrote: >> From: Wei Wang >> >> There is a race condition when accessing kvm->arch.apic_access_page_done. >> Due to it, x86_set_memory_region will fail when creating the second vcpu >> for a svm guest. >> >> Add a mutex_lock to serialize the accesses to apic_access_page_done. >> This lock is also used by vmx for the same purpose. >> >> Signed-off-by: Wei Wang >> Signed-off-by: Amadeusz Juskowiak >> Signed-off-by: Julian Stecklina >> Signed-off-by: Suravee Suthikulpanit > Reviewed-by: Joerg Roedel Queued, thanks. Paolo