Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4944309imu; Sun, 25 Nov 2018 13:22:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/XAFQWXseIFCEsqgA76HLdPhLMHoV8g0tdNabEVJH6x4/868edeGPkDWVO70yEHT4AsXW6q X-Received: by 2002:a17:902:20c8:: with SMTP id v8mr5973767plg.319.1543180925271; Sun, 25 Nov 2018 13:22:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543180925; cv=none; d=google.com; s=arc-20160816; b=iKzKH9sGDAw+au7PZXB0a4cmpL1UY9zc0Fp8yDgtPNQ61BGen+E2VoNoe1LMmsL/vG 01S+QLBbUFyQbwpSD0N55/iBhjFJAG+PQv+dTdRKQSmmLlCRdQS3aoY+ewhnyiPifqT8 aitvbcJYEFCQEEa+jevUuHdq0Nv1iEu0wd9eEMNOaxFkpxxkp0mCpDRjqoUVJnnP35bt +TJfedeY6RmvDL/bVTt/mNyDW8FFG9k9ZxyAsk0nsHPFbMmaTBuEBBfTiyP/sFZa/UmO 8WgPgjr4RTuz9jYZEXqqlUSusN9f4lbwSm3AvJZSJqTPphqsRe6d+uHfYxXbMX/dw/iE fD+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:organization :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=C6R+qDyqlpWn0q3ocsfJiX9fqgAizmAInnj+rDl9fvk=; b=ANRrsT/jqBKM3scWOU2z2tFDCD4cjqjUJGVsVDs1Y8dITGs8YtRtQ0RC5jVd3/ox4W BX3smPqx4JoiTwcmga1E+os1/QJveoJ6gmiNXgvYWTsGbXUzpBWpSTv5ZVSXsiD0RzZM 385xNiKq8fwL/reaFrz989hbtSD55pbAVlkg0AVoqkP+c1NGwg7zsX2gpRTqc7d3rlEX nc5YlD1KDi7eew3lUXU5kp/OWBKufg67gYi57V9kWLsDfwr1frr7rkmrp16Z2IeCICIh SC54wXAoDsjLJ1EMOJI8+h36gCBPE++02D9xP3/eC+4aT6EeYHe5UxV4nD6H16kzzBKY KHxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a11si56682035pga.198.2018.11.25.13.21.50; Sun, 25 Nov 2018 13:22:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbeKZILk (ORCPT + 99 others); Mon, 26 Nov 2018 03:11:40 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42835 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbeKZILj (ORCPT ); Mon, 26 Nov 2018 03:11:39 -0500 Received: by mail-qt1-f194.google.com with SMTP id d19so15472174qtq.9; Sun, 25 Nov 2018 13:19:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:organization:content-transfer-encoding; bh=C6R+qDyqlpWn0q3ocsfJiX9fqgAizmAInnj+rDl9fvk=; b=A87tFJQ1+0PJJ24u8tpnIwc9A/bNdvJDT1KEcE03/MqgXwTNADMsG+QFr4hj7VvMO6 sRyWt2Hc0SSs2jlfWkhL7a7IbuA0a1+qUg601pctEfeYiQmc1VRPtlJIJFiPWP9RWo4K xpUMhhIyv2dWcFFhxTLnBIc8pwOZh0ImPw2cWCpxLDh3yjkpg7CEoKlHWfGJjeB+n9iH isxCF1zrb3c5Hd4ne7JVIIQkssLoPNG4roU5AVkj0HBuw222U+BG7jRfVQ6XAWP85ubC Afq3qDfLXFaAUuDWdNr8B/F+WJq8jJbhKhKOjL09V4sDnsqf+HAgGlELTwS0xDmYJc+r 2m5Q== X-Gm-Message-State: AA+aEWboOSoEduTHudBauR+znsPptf/J1r7lNrL+0182u5PQvFKDpJ82 Hcz6B06Xzyai/7eAX/kkb14iENXx X-Received: by 2002:a0c:89b4:: with SMTP id 49mr23454409qvr.85.1543180779340; Sun, 25 Nov 2018 13:19:39 -0800 (PST) Received: from localhost.localdomain ([181.220.65.91]) by smtp.gmail.com with ESMTPSA id a54sm25897391qtc.17.2018.11.25.13.19.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Nov 2018 13:19:38 -0800 (PST) Received: by localhost.localdomain (sSMTP sendmail emulation); Sun, 25 Nov 2018 19:19:32 -0200 From: Otavio Salvador To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: Otavio Salvador , Fabio Berton , Jose Abreu , Giuseppe Cavallaro , netdev@vger.kernel.org, Alexandre Torgue , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, "David S. Miller" Subject: [PATCH 04/13] net: stmmac: dwmac-rk: Do not print redundant error message Date: Sun, 25 Nov 2018 19:18:58 -0200 Message-Id: <20181125211907.9895-4-otavio@ossystems.com.br> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181125211907.9895-1-otavio@ossystems.com.br> References: <20181125211907.9895-1-otavio@ossystems.com.br> MIME-Version: 1.0 Organization: O.S. Systems Software LTDA. Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rk_gmac_setup() already prints a message saying that the PHY regulator is not found, so we should not print it again. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 73855622445b..c895a9a6939a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1203,10 +1203,8 @@ static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable) int ret; struct device *dev = &bsp_priv->pdev->dev; - if (!ldo) { - dev_err(dev, "no regulator found\n"); + if (!ldo) return 0; - } if (enable) { ret = regulator_enable(ldo); -- 2.19.1