Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181125211907.9895-1-otavio@ossystems.com.br> <20181125211907.9895-2-otavio@ossystems.com.br>
In-Reply-To: <20181125211907.9895-2-otavio@ossystems.com.br>
From:   Olof Johansson <olof@lixom.net>
Date:   Sun, 25 Nov 2018 14:25:04 -0800
Message-ID: <CAOesGMjR--5XC1pNMkPHR9BaPfgGfdC8JHAM3oqS3Xte3TQbGA@mail.gmail.com>
Subject: Re: [PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options
To:     Otavio Salvador <otavio@ossystems.com.br>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        fabio.berton@ossystems.com.br, yannick.fertre@st.com,
        Arnd Bergmann <arnd@arndb.de>, Eric Anholt <eric@anholt.net>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Stefan Agner <stefan@agner.ch>,
        Tony Lindgren <tony@atomide.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Russell King <linux@armlinux.org.uk>,
        Simon Horman <horms+renesas@verge.net.au>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Nov 25, 2018 at 1:19 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> From: Fabio Berton <fabio.berton@ossystems.com.br>
>
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Hi Otavio,

Thanks for these patches. I don't have a reason to _not_ enable
systemd features, but would you mind providing a brief description of
what's not working without this change? Is it completely broken, or is
it just the random-UID featues that don't work, or something else?.
Useful for others to know what's expected to break if someone turns
them off, etc.

Also, I noticed you posted a series of 13 patches, which includes some
dts files for rv1108, some network driver changes and some of these
more generic defconfig changes. I would suggest that you split up your
patches into independent series where possible, especially when they
end up going to different subsystems. Providing suitable cover letters
for the series when you post them is also useful to help reviewers by
summarizing the series, including changes from last time it was
posted, etc. Please address it to the superset of patch receivers on
the series.

I'm asking for the cover letter because this time I was wondering if
there was a reason for the mix of patches so I went looking for it.
Maybe there is a need to group them together even though the
sub-series seem somewhat independent -- I can't tell from the way they
were posted.


Thanks!

-Olof