Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Otavio Salvador <otavio.salvador@ossystems.com.br>
MIME-Version: 1.0
References: <20181125211907.9895-1-otavio@ossystems.com.br>
 <20181125211907.9895-2-otavio@ossystems.com.br> <CAOesGMjR--5XC1pNMkPHR9BaPfgGfdC8JHAM3oqS3Xte3TQbGA@mail.gmail.com>
In-Reply-To: <CAOesGMjR--5XC1pNMkPHR9BaPfgGfdC8JHAM3oqS3Xte3TQbGA@mail.gmail.com>
Date:   Sun, 25 Nov 2018 21:10:51 -0200
Message-ID: <CAP9ODKrTZm8FuRWLh+5NZSbpMh_yptotdoEgfrARHypUx8FkMg@mail.gmail.com>
Subject: Re: [PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options
To:     olof@lixom.net
Cc:     Otavio Salvador <otavio@ossystems.com.br>, stefan.wahren@i2se.com,
        Fabio Berton <fabio.berton@ossystems.com.br>,
        alexandre.torgue@st.com, arnd@arndb.de, eric@anholt.net,
        Tony Lindgren <tony@atomide.com>,
        Kernel development list <linux-kernel@vger.kernel.org>,
        Stefan Agner <stefan@agner.ch>,
        Russell King <linux@armlinux.org.uk>, yannick.fertre@st.com,
        linux-rockchip@lists.infradead.org, horms+renesas@verge.net.au,
        geert+renesas@glider.be, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Olof,

On Sun, Nov 25, 2018 at 8:25 PM Olof Johansson <olof@lixom.net> wrote:
> Thanks for these patches. I don't have a reason to _not_ enable
> systemd features, but would you mind providing a brief description of
> what's not working without this change? Is it completely broken, or is
> it just the random-UID featues that don't work, or something else?.
> Useful for others to know what's expected to break if someone turns
> them off, etc.

Thank you for your kindness reviewing this. I am not an experienced
Linux kernel contributor so I am going to do some mistakes during this
process.

We usually follow the required feature set listed on Gentoo wiki[1] as
it is usually up to date and avoids a lot of headaches for us when
dealing with boot issues with SystemD.

1. https://wiki.gentoo.org/wiki/Systemd#Kernel

Do you think mentioning where it has been taken from is enough?

> Also, I noticed you posted a series of 13 patches, which includes some
> dts files for rv1108, some network driver changes and some of these
> more generic defconfig changes. I would suggest that you split up your
> patches into independent series where possible, especially when they
> end up going to different subsystems. Providing suitable cover letters
> for the series when you post them is also useful to help reviewers by
> summarizing the series, including changes from last time it was
> posted, etc. Please address it to the superset of patch receivers on
> the series.

I can certainly improve it for the next submission. Should I split
them all and tag them v2 to easy it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750