Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5374458imu; Sun, 25 Nov 2018 22:42:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/UtvEUmJGRWAtr3NlSyy9xBBCfF+Brnvs8l3vJ06l4+ap8bRgVZINIOsQaRzpqOt58qJhZF X-Received: by 2002:a17:902:aa4c:: with SMTP id c12mr23572440plr.48.1543214531815; Sun, 25 Nov 2018 22:42:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543214531; cv=none; d=google.com; s=arc-20160816; b=Q6CfQw/Z7GPSxOVrezMs+B+jVEW1zGhN5BWbaUQFJkSrj0eVfiQv/tEO1hyl8IpEoc clrLDYRlh7tupppHzfrBTDF0Ot0YFNSy39x2g55y3ev9cFC5xpOj1yn0hmxlwQVb/hxQ IBci3yLKalyyWO9AEZ6TZh6GDXHInmnHjIHRNpV7ss2meLQDRHcLqEopUJJ9A2illAoz Sa6sOnjUoGqngsRZ4InfeqIV13jQFWXP68joUGu3UmJGToHnunN+QbBk6XEP6vqs0xuO DlLQtmzOAVCN6thBnR+kzzfHg3+zWLoTerniXSDThHvcppfTFh/LRj5jKnLKKMNPyaLb HzhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=+1+t0Z/ZfU5S2UajHpSYF/pcztXvYCA2vpbpajrIQCo=; b=smug8/LZSRxcuCCqt0IhvNH7tNoGz60taBQZg16A9ONjrqQ/E7skj00cUp+vbKqR0V dQ8GFi2OtjMFcev8rWwvt5F2XPNzbrIGlW1/NHQeRti0wPjEz7Ri5KxSRudnFFcw/cFR F8G7bsRKRZ3aVXqeu/SS0p1ZlhoxensX4i1Zm9Zm0pVErZdPtwPbrU//WDmWw33X1yqi nndIrc+bHNIGW7OpfVafOXyBw4fyZ6qGxEemwP8hacD62/l+y68GDvd+yI/mJIUXfKhD bvsPJ3AyAYjzOYEGa84cYcB20QCBf/71EYRerAYB2i3OgHHjovHssQ4+PfZBY0XoQVVA ZolQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t23si61732518pgi.181.2018.11.25.22.41.29; Sun, 25 Nov 2018 22:42:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbeKZRc7 (ORCPT + 99 others); Mon, 26 Nov 2018 12:32:59 -0500 Received: from mail-sz2.amlogic.com ([211.162.65.114]:46653 "EHLO mail-sz2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbeKZRc6 (ORCPT ); Mon, 26 Nov 2018 12:32:58 -0500 Received: from [10.28.18.115] (10.28.18.115) by mail-sz2.amlogic.com (10.28.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 26 Nov 2018 14:39:58 +0800 Subject: Re: [PATCH v7 0/2] mtd: rawnand: meson: add Amlogic NAND driver support To: Jianxin Pan , Boris Brezillon , CC: David Woodhouse , Miquel Raynal , Brian Norris , Marek Vasut , Richard Weinberger , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Carlo Caione , Kevin Hilman , Rob Herring , Yixun Lan , Jian Hu , Hanjie Lin , Victor Wan , , , , References: <1542386439-30166-1-git-send-email-jianxin.pan@amlogic.com> From: Liang Yang Message-ID: <9c340a88-06a1-2b81-f435-f9da338077ba@amlogic.com> Date: Mon, 26 Nov 2018 14:39:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <1542386439-30166-1-git-send-email-jianxin.pan@amlogic.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.28.18.115] X-ClientProxiedBy: mail-sz2.amlogic.com (10.28.11.6) To mail-sz2.amlogic.com (10.28.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris and Miquel, How about the v7 patch? On 2018/11/17 0:40, Jianxin Pan wrote: > These two patches try to add initial NAND driver support for Amlogic Meson > SoCs, current it has been tested on GXL(p212) and AXG(s400) platform. > > Changes since V6 at [7] > - use timings->tBERS_max as the maximum time out, delete NFC_CMD_RB_TIMEOUT > - fix nand_rw_cmd and support small block flash and which row address less than 3 > - fix coding style > - replace readl/writel_* with readl/writel_relaxed* > - delete ECC_SET_PROTECTED_OOB_BYTE and ECC_GET_PROTECTED_OOB_BYTE > - implement dma access for read_buf and write_buf, more efficient. > - delete waiting dma finish in write process and let NAND_CMD_PAGEPROG and > RB command go on queuing > - add waiting the completed flag of last ecc page be set, for more strict >