Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Vincent Chen' <vincentc@andestech.com>
CC:     "green.hu@gmail.com" <green.hu@gmail.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Nick Chun-Ming Hu(?????????)" <nickhu@andestech.com>,
        "deanbo422@gmail.com" <deanbo422@gmail.com>
Subject: RE: [PATCH v4 2/5] nds32: Support FP emulation
Thread-Topic: [PATCH v4 2/5] nds32: Support FP emulation
Thread-Index: AQHUghG4/qfbmySOskGwd6CmLmV7sqVdK4IggAQdiQCAAJRa0A==
Date:   Mon, 26 Nov 2018 10:18:01 +0000
Message-ID: <3dcd9764570e4565911b74b08513e2d3@AcuMS.aculab.com>
References: <1542856478-795-1-git-send-email-vincentc@andestech.com>
 <1542856478-795-3-git-send-email-vincentc@andestech.com>
 <f0d20a4682b740659f28184c1278ae7d@AcuMS.aculab.com>
 <20181126012310.GA26621@andestech.com>
In-Reply-To: <20181126012310.GA26621@andestech.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Vincent Chen
> Sent: 26 November 2018 01:23
> On Fri, Nov 23, 2018 at 06:53:37PM +0800, David Laight wrote:
> > From: Vincent Chen
> > > Sent: 22 November 2018 03:15
> > >
> > > The Andes FPU coprocessor does not support denormalized number handling.
> > > According to the specification, FPU generates a denorm input exception
> > > that requires the kernel to deal with this instrution operation when it
> > > encounters denormalized operands. Hence an nds32 FPU ISA emulator in the
> > > kernel is required to meet requirement.
> >
> > What does the FPU generate for results near zero?
> 
> 1. The calculation result is a denormalized number
> Depending on the state of underflow trap, the FPU will raise an underflow
> exception or flash the result to zero.
> 
> 2. One of the operands is a denormalized number
> Depending on the state of the flash-to-zero mode, the FPU will raise a
> denormalized input exception, which is a specific exception of the nds FPU,
> or directly treats the operand as 0.

You didn't mention (1) in the commit message.

It ought to be possibly for the exception routine to rescale the values,
re-issue the same FP instruction, then scale the result.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)