Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5619187imu; Mon, 26 Nov 2018 03:05:43 -0800 (PST) X-Google-Smtp-Source: AFSGD/VXK1TVCdWsLMNIVNpRh3cdJUZCIvFBaAbt8S9AjH6xqDHCHiGKzjIK6PH0frqR9oqTW+76 X-Received: by 2002:a17:902:8bc6:: with SMTP id r6mr26990924plo.67.1543230343267; Mon, 26 Nov 2018 03:05:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543230343; cv=none; d=google.com; s=arc-20160816; b=eU9jX2nhcxZvXf7GeO+cUqIwzhW2T4CqJFWfweNRKmCYPlgZw5t3lAi9rkOW91TqPW 2L4/lwg7l7UGnWLV97IfUvrw1SBlvSxIx0AxHw4Fxz7Ho3q5C3pScCqNHwx0XUccnVPq GZBcm+9WjpDlUB93BXsWKYHgnLopqGhwmMXKRgc17Ky/lzhclhKzYz89sHDqn6I8Cw5j KBcDg4qUxDxIdhvbkr77OvrQzDLW24etyYiozVT7uzBvvDzBq1o0XL0At0MYwavpNX5U DOTtV5yhC/JBhudtKP+Xonr/0C/MMDfOoOTRy4o5OIPBZMPtlySRY2Bkvl3ifMlPR7Ny 66uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UZThwrjh64mN/d3WYsNndsU9WcHEbFf9YQ6hIr3bEww=; b=y27wmD3+yBBNqBO0X5AALXVLqmi7sdCh4sKMKIPZ6HLCgTLxgURJLrUnh2+55QRBlS ArYu0S4pCATnsVRqVwLUno36QsvUtEVlsZLuEG408u9IevZFx3c9pXJ272BCMKBkodaD xKZLaoyUUkXiFLoa/HGFu6I2+1wssgK/YciZ1AA8i5TY271avV5kDsCFdL3TJb2qs2qJ pSXKKRHNLnfTnwklvfSMGjJq9YOea2Ejsg6dNsVkbIHqWS8bIbLLe5I8K9ZEYDnjAm7l oqWaeXRPCmRO581Ta2SQ1gPNBF/wxL8nreK1ywjgr9fECvNbloXk8z9hKD8k5orLe93h TWUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pStg9ICG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7si35029224pfo.108.2018.11.26.03.05.25; Mon, 26 Nov 2018 03:05:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pStg9ICG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731124AbeKZV6f (ORCPT + 99 others); Mon, 26 Nov 2018 16:58:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:43884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbeKZV6f (ORCPT ); Mon, 26 Nov 2018 16:58:35 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE15620672; Mon, 26 Nov 2018 11:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543230289; bh=9U5DRpVWBsvViSDMUEXgjtdoXkcjRTUmq0Jch9Wm098=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pStg9ICGvtsrKzKyhWiduMOxm72hLFyMFjxD+Fl53kNCTahVJdJ+dljKL6EQoIj8s JvdqohpP0/TXEUXAWW91/VuSq5b6MSapvqiX5Fk6qPN5LkS8Hb9hsmk23I0B0H489o Xu4E9s2yHvtGMqj1zPVRByBBRiYSS4LGS7evCBq0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Borkmann , Sandipan Das , Song Liu , Alexei Starovoitov , Sasha Levin Subject: [PATCH 4.19 046/118] bpf: fix bpf_prog_get_info_by_fd to return 0 func_lens for unpriv Date: Mon, 26 Nov 2018 11:50:40 +0100 Message-Id: <20181126105102.663939142@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181126105059.832485122@linuxfoundation.org> References: <20181126105059.832485122@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 28c2fae726bf5003cd209b0d5910a642af98316f ] While dbecd7388476 ("bpf: get kernel symbol addresses via syscall") zeroed info.nr_jited_ksyms in bpf_prog_get_info_by_fd() for queries from unprivileged users, commit 815581c11cc2 ("bpf: get JITed image lengths of functions via syscall") forgot about doing so and therefore returns the #elems of the user set up buffer which is incorrect. It also needs to indicate a info.nr_jited_func_lens of zero. Fixes: 815581c11cc2 ("bpf: get JITed image lengths of functions via syscall") Signed-off-by: Daniel Borkmann Cc: Sandipan Das Cc: Song Liu Signed-off-by: Alexei Starovoitov Signed-off-by: Sasha Levin --- kernel/bpf/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 675eb6d36e47..382c09dddf93 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -1974,6 +1974,7 @@ static int bpf_prog_get_info_by_fd(struct bpf_prog *prog, info.jited_prog_len = 0; info.xlated_prog_len = 0; info.nr_jited_ksyms = 0; + info.nr_jited_func_lens = 0; goto done; } -- 2.17.1