Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5621570imu; Mon, 26 Nov 2018 03:07:24 -0800 (PST) X-Google-Smtp-Source: AFSGD/WigjdlYV3xKCQ9C5rhRXjSYTvC3+52ExBYTqyswm5s5MRkHnu0kQVB7tFY6RcFl2G3NKcd X-Received: by 2002:a17:902:161:: with SMTP id 88mr12084005plb.306.1543230444881; Mon, 26 Nov 2018 03:07:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543230444; cv=none; d=google.com; s=arc-20160816; b=rW6kTS1i1U/25bKUlTOSlZskfp/eGz0uYZUO9Vgwj+vPIJf1t0V52hB7Oq/A4C4mIy lmoaVJ5+tHS6nbGjpo9JedBORWOGjXDr7EbeF+893bCAafA+UHwKqu4bbeZ7BQvnkNi3 bVI0HWf+iyfTCcUdb1errkhVJrLlgEAuoQhScrK+x/zRz2Fz+G+ur0zoq7PrsvHWULwV W05U4MVx1yJcKvEWmcTLnF+pR4ZlSMI0l5QrkdLRFrO2MV5gtgL8SheVJlu6KGflk00L C+ygB6cgE4L9RdQs2L9PYxWJk3+HJ57FYURhxrE/ibjD1odiknqaU5hbdICWQYNyLW2F kimQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=q9iiacdWOkNZrqDWWEQEYAIMTMNT1ZWCPCHbbpYE4qs=; b=gDUw3MPpOqzgsWhco9GIsTGfgJV0+OToM1FDiKfg/hur9yEKVbfn4Wx/kaOyUoJOet 9LAo/+dsp4tVMds2tS85/P7Yt2Z55eskEe3PT+LLRVSI8BbLQ+9jHZIR1TS/PpuDk1qV UA92avTC6To4PeSC/poGeZRiA2AXEI9CVOaxn+UQUlaRJzHZjnVgJcpGjr6vOYZ5Qy5+ /w2eJZXbzG3jsaQcu+BxKn7PrdXO7jcLgcvqFNfJnOQJFl7U7qTo2OHfbzX20VOj3Bs/ LM13hLOUTdp4QxMCU44wvRB6LGEEoy+Qb1Zkm+Dve77VUregHUi/FOlGfKbikhbRA9m/ E1Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zlViChRk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e63si59560721pgc.239.2018.11.26.03.07.11; Mon, 26 Nov 2018 03:07:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zlViChRk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731553AbeKZWAJ (ORCPT + 99 others); Mon, 26 Nov 2018 17:00:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:46846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729543AbeKZWAI (ORCPT ); Mon, 26 Nov 2018 17:00:08 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2446620645; Mon, 26 Nov 2018 11:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543230382; bh=saohxsP9pObiHYLkTJpS582mfNLXaIsBv8yc+ef2yTM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zlViChRkgxe/dVlLayl9zqffEvCIEekLr9Q1IbjSVF8B+LEzn9uaMOvrxXtrhMtnm zI7C7AE35PJeqtYlrz7husX1iPgipHkfZRaq1ah3ku6qYe99Ik3odx+X1QHkMrSbVQ WWvJpw+ibN7kNy4Ds2IE1njGSLHCHOIjEzxk3Ig0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jacob Keller , Andrew Bowers , Jeff Kirsher , Sasha Levin Subject: [PATCH 4.19 080/118] i40e: restore NETIF_F_GSO_IPXIP[46] to netdev features Date: Mon, 26 Nov 2018 11:51:14 +0100 Message-Id: <20181126105104.873110907@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181126105059.832485122@linuxfoundation.org> References: <20181126105059.832485122@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit ba766b8b99c30ad3c55ed8cf224d1185ecff1476 ] Since commit bacd75cfac8a ("i40e/i40evf: Add capability exchange for outer checksum", 2017-04-06) the i40e driver has not reported support for IP-in-IP offloads. This likely occurred due to a bad rebase, as the commit extracts hw_enc_features into its own variable. As part of this change, it dropped the NETIF_F_FSO_IPXIP flags from the netdev->hw_enc_features. This was unfortunately not caught during code review. Fix this by adding back the missing feature flags. For reference, NETIF_F_GSO_IPXIP4 was added in commit 7e13318daa4a ("net: define gso types for IPx over IPv4 and IPv6", 2016-05-20), replacing NETIF_F_GSO_IPIP and NETIF_F_GSO_SIT. NETIF_F_GSO_IPXIP6 was added in commit bf2d1df39502 ("intel: Add support for IPv6 IP-in-IP offload", 2016-05-20). Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index ac685ad4d877..6eccfa82ca94 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -11926,6 +11926,8 @@ static int i40e_config_netdev(struct i40e_vsi *vsi) NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM | NETIF_F_GSO_PARTIAL | + NETIF_F_GSO_IPXIP4 | + NETIF_F_GSO_IPXIP6 | NETIF_F_GSO_UDP_TUNNEL | NETIF_F_GSO_UDP_TUNNEL_CSUM | NETIF_F_SCTP_CRC | -- 2.17.1