Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5634842imu; Mon, 26 Nov 2018 03:18:26 -0800 (PST) X-Google-Smtp-Source: AFSGD/X7u6+7t0kdRR2dMcJOK4Rre2yrIzDOvu2J/H7OeDdWwHBQ7tMZjMOpvzrj6JH85icQtnbW X-Received: by 2002:a17:902:12b:: with SMTP id 40mr12809371plb.72.1543231106167; Mon, 26 Nov 2018 03:18:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543231106; cv=none; d=google.com; s=arc-20160816; b=KVUbdZnJJ56opUrM479aJiNwCohnSmKL6fTqv4U/bCCyJhaX2eEjeKvr+T2kU49tOn 9siMZRI3uyjQYTQaCYZmvRry7rMcQb53Y1gnIIcVaniU+2A3moeUxAgfubJUTlvKatdK 9Cpcye6rwSr7YUE6hb5fXtB2sIuUpQZrMPjnW4nr6rGOW4XX94rvgYvAlxmGI2zl+xP2 cSNL7k8qtIfvs6mW94KE/075E/NOh6mWAAkNrvx5qG+aJE0q5Vf0q+dhb5syLAIpRmO5 jbiAKsxq7zbvHnbjMbFRdfkjt/1pDrIgBCcuLb81ttqIUSKzq0WGq7/WT75A4K0hwfX4 2qGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DtWPzfEXsffcc92bMyt0VsPSAjV+uc7C0kq+tHmczaM=; b=k92FvgKvJh27WBLIVkMfueLiMjuB5eAi4CwnUKMV/f/RS85kFIMLAg3igmwo40PuYT W2yon5+I3Ej73/mH0Vgr6LltwKrFEyDHMeaEKJqL35em9gzVd5cM7xYbIrp0VCHuAVmK 9m8EROj0Rb27pZjGq/qRIxMYL6FJOX1/d91ar6fhf798o0uZoeoTbGYXF9/CYfuwi7iu WWiCb3RbM1t+8H522FPdCaTRxEAdvIYwlp7Tm8Tlo0F+WpNz9LQYAg0Us0RfpkFkmSlv cRiKGLgvvGByJYs2C6FdzPoemMAlAQ25adDu4su9bqnUbFnyXk6hMOqZhpIak1M/GXWo RIWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w0xQrFf/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19si51495648pgj.375.2018.11.26.03.18.11; Mon, 26 Nov 2018 03:18:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w0xQrFf/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730096AbeKZVzF (ORCPT + 99 others); Mon, 26 Nov 2018 16:55:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:37450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbeKZVzE (ORCPT ); Mon, 26 Nov 2018 16:55:04 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27F1E21104; Mon, 26 Nov 2018 11:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543230078; bh=jvrwHZVV4cT8W5FZXYB+nas78cWmFqmYpv0vCSRaxzs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w0xQrFf/sAGW/GTjhlNviK7SC85jM2SylhE3I5JWTeDmVx7ptOLctiYRGwJ6OMGZQ az3dsx9b2gbjIH6v+nz9uXKBflvUNaMqmYN9ZxhqYMPcpT0Sn6cejk5COCPtlvN0L/ viUWT0fYaj0IiX48evIL8hoPYU6JIDmvHovbKhLo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jacob Keller , Andrew Bowers , Jeff Kirsher , Sasha Levin Subject: [PATCH 4.14 35/62] i40e: restore NETIF_F_GSO_IPXIP[46] to netdev features Date: Mon, 26 Nov 2018 11:51:16 +0100 Message-Id: <20181126105053.560584053@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181126105050.592727680@linuxfoundation.org> References: <20181126105050.592727680@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit ba766b8b99c30ad3c55ed8cf224d1185ecff1476 ] Since commit bacd75cfac8a ("i40e/i40evf: Add capability exchange for outer checksum", 2017-04-06) the i40e driver has not reported support for IP-in-IP offloads. This likely occurred due to a bad rebase, as the commit extracts hw_enc_features into its own variable. As part of this change, it dropped the NETIF_F_FSO_IPXIP flags from the netdev->hw_enc_features. This was unfortunately not caught during code review. Fix this by adding back the missing feature flags. For reference, NETIF_F_GSO_IPXIP4 was added in commit 7e13318daa4a ("net: define gso types for IPx over IPv4 and IPv6", 2016-05-20), replacing NETIF_F_GSO_IPIP and NETIF_F_GSO_SIT. NETIF_F_GSO_IPXIP6 was added in commit bf2d1df39502 ("intel: Add support for IPv6 IP-in-IP offload", 2016-05-20). Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 04dbf64fb1cb..176c99b8251d 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9688,6 +9688,8 @@ static int i40e_config_netdev(struct i40e_vsi *vsi) NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM | NETIF_F_GSO_PARTIAL | + NETIF_F_GSO_IPXIP4 | + NETIF_F_GSO_IPXIP6 | NETIF_F_GSO_UDP_TUNNEL | NETIF_F_GSO_UDP_TUNNEL_CSUM | NETIF_F_SCTP_CRC | -- 2.17.1