Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 01:37:24 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     David CARLIER <devnexen@gmail.com>
Cc:     linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
        gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
        aryabinin@virtuozzo.com, Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] Little memset_explicit optimisation
Message-ID: <20181126113724.svbv6np25fzxkhrm@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        David CARLIER <devnexen@gmail.com>, linux-kernel@vger.kernel.org,
        alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org,
        andriy.shevchenko@linux.intel.com, aryabinin@virtuozzo.com
References: <CA+XhMqyR1wMEnEE2cCnoGj2RatxTbFuNH2jOj1-50iYso67rAw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ues3xolvxrd43lmw"
Content-Disposition: inline
In-Reply-To: <CA+XhMqyR1wMEnEE2cCnoGj2RatxTbFuNH2jOj1-50iYso67rAw@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ues3xolvxrd43lmw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 24, 2018 at 12:35:43PM +0000, David CARLIER wrote:
> Using the return value of memset for save/load sake.
>=20
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
>  lib/string.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/string.c b/lib/string.c
> index 38e4ca08e757..92da04a0213b 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -720,7 +720,7 @@ EXPORT_SYMBOL(memset);
>   */
>  void memzero_explicit(void *s, size_t count)
>  {
> -       memset(s, 0, count);
> +       s =3D memset(s, 0, count);
>         barrier_data(s);
>  }
>  EXPORT_SYMBOL(memzero_explicit);

Could you elaborate on the optimization that this patch performs?

--=20
Cheers,
Joey Pabalinas

--ues3xolvxrd43lmw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv72vMACgkQ2rGdfm9D
tVJr9Q/+LUn12Ov3tI8izc5J2EKpfM11GDqdt0K5QW/z5bNhn8PDXqy8VcNjww7I
58XkpvXphDy+zBUjVs3HGtEJnMDfP85g7xA784HomWoMt/QrmiiIYzuphOoVLpb1
iw2/ExifO11otq7NDHWTeMYuiVQ4xadc/D47lP/ADzzcRo0EWy35xcVIp9U1oJgT
HwNyOq5vda/j01TEnHRd91Psh2kIHdNtpQ6f6U3t0eQ0Mx3O5ymCEfemFgWFPP0r
sD34T4lhfQ29LcK4lyabj2DpIE3+3wOb6UOTILRaHNrSJKhfmNVvqmzy9jT/ZDLF
oEl4XtaPWoYMkuRGC7GQRfR8cwdHdwUlnvypwKru8a+2tP6M3P83U6XB4lCvVGnv
q9nGwZqltwfOCuwHqdJ20OSA1wBtV/jy2YxVPVWf0w3L2UOqVUmBrMa7jhRzSh5j
+dCKg/MqyAxnzX4EWVapZN/FV8pd4jjOiAD0UWp9ZOkOLndxYLgzbGplzp6Yut+8
RG9EDI0Da3L5hcyhh0eNY4ReoQDzqAoxZzdNZRf79jj63m/jLpCTcCbs9IdYPy9E
A/xol1K/I8qp8hxzo1EVqGZFU5t/Wz3KSNaaWGmkt0/19XvPKoHDyv0z3UkEuwZb
2Vs6lNLl4gDQkweKLq5o10lHAgEW48s5n4TliECd3ZZjSLNRkyQ=
=zYWT
-----END PGP SIGNATURE-----

--ues3xolvxrd43lmw--