Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5757264imu;
        Mon, 26 Nov 2018 04:58:17 -0800 (PST)
X-Google-Smtp-Source: AFSGD/VfPM0sQ95Cgsx1TDNKKSaHtKSmHi4BA96FHoS5kjq/6vFzkgBcSgI6Cqs6woYTcSZeRxKk
X-Received: by 2002:a62:1e87:: with SMTP id e129mr14963631pfe.221.1543237096947;
        Mon, 26 Nov 2018 04:58:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1543237096; cv=none;
        d=google.com; s=arc-20160816;
        b=NDcdVwAOQbt6IDjpRj3hhJp6Ti9YR7CoN+fTRhWjahv2KuI1hCv3wmU0LNP0jaK0sP
         D4oAMVGQSCTuz/0n0DGTheC2PIjzcKtX4DID49kMdD9ENivZtq1CDWk0SVJqfiG/8VGx
         7PUBFCZNbnzs4pBORTI5O5OaMcn4Hl54Ima3MwaxDH3V2kimU/nnJRhbixMVSBrP6N5+
         BJ7d/MLx/sPMGE1NJa4yj+QxhUaWPOZjWpmDL5gl0lXbhZiSNc08xaQQMWDK6On0ygv/
         6uVgEjq87DV7y0qg91QA5HIbOVAT3WRfIiDNycANEDb9XZMnYvvVlXjOHNoPt5AWG39B
         6f7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=0OMIcU6oBaKpOcdRL3Qfygx3ST5OGfWoRFNRA0oG7QQ=;
        b=aFt9LvHQfFIvp7QpP017ADNDkMctqYdADANGnCowlKrnXADPsDwMfV8sZsPls43Vd7
         xYZLFH9Xibuj5vvJEFzLMnBkqGBbIGEaGsDO/ldAzY15X0AKIsvbBKeydAQx2M3aAGwP
         fyWjx/ANBeLRHkB70tsTaHpvwl7xGNRUGQq23WuOWA6VYmeBlvrx+AdiI1nm5Nnk9WRs
         VpNjk41iByoCcCnZANi1L0SFwxajkWn052i4QXZerK8xy0eRkpioL6Iq1KtHVaOm5ULp
         X9RlzRHWSW19/SH+yL3ax+SD8u5iMUyk4Ur3/P5uzNNBgK0Voxy2paGbKaj0h5RTGnJB
         p/Ow==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id v8si263966ply.126.2018.11.26.04.57.47;
        Mon, 26 Nov 2018 04:58:16 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726923AbeKZXtz (ORCPT <rfc822;uzarths@gmail.com> + 99 others);
        Mon, 26 Nov 2018 18:49:55 -0500
Received: from verein.lst.de ([213.95.11.211]:51851 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726525AbeKZXtz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Nov 2018 18:49:55 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 7A46F68BF4; Mon, 26 Nov 2018 13:55:49 +0100 (CET)
Date:   Mon, 26 Nov 2018 13:55:49 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Theodore Ts'o <tytso@mit.edu>, Omar Sandoval <osandov@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Dave Chinner <dchinner@redhat.com>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
        linux-raid@vger.kernel.org, David Sterba <dsterba@suse.com>,
        linux-btrfs@vger.kernel.org,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        linux-xfs@vger.kernel.org, Gao Xiang <gaoxiang25@huawei.com>,
        Christoph Hellwig <hch@lst.de>, linux-ext4@vger.kernel.org,
        Coly Li <colyli@suse.de>, linux-bcache@vger.kernel.org,
        Boaz Harrosh <ooo@electrozaur.com>,
        Bob Peterson <rpeterso@redhat.com>, cluster-devel@redhat.com
Subject: Re: [PATCH V12 08/20] block: introduce bio_for_each_bvec() and
 rq_for_each_bvec()
Message-ID: <20181126125549.GD6383@lst.de>
References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-9-ming.lei@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181126021720.19471-9-ming.lei@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 26, 2018 at 10:17:08AM +0800, Ming Lei wrote:
> bio_for_each_bvec() is used for iterating over multi-page bvec for bio
> split & merge code.
> 
> rq_for_each_bvec() can be used for drivers which may handle the
> multi-page bvec directly, so far loop is one perfect use case.
> 
> Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>