Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 03:44:38 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Joey Pabalinas <joeypabalinas@gmail.com>,
        Minchan Kim <minchan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v2 5/7] zram: support idle/huge page writeback
Message-ID: <20181126134438.7shen7saoo2mifmo@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Minchan Kim <minchan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
References: <20181126082813.81977-1-minchan@kernel.org>
 <20181126082813.81977-6-minchan@kernel.org>
 <20181126094737.sfudpeoigra2vir7@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="p54u7efpquuy2ne2"
Content-Disposition: inline
In-Reply-To: <20181126094737.sfudpeoigra2vir7@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--p54u7efpquuy2ne2
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote:
> > +		if ((mode & IDLE_WRITEBACK &&
> > +			  !zram_test_flag(zram, index, ZRAM_IDLE)) &&
> > +		    (mode & HUGE_WRITEBACK &&
> > +			  !zram_test_flag(zram, index, ZRAM_HUGE)))
> > +			goto next;
>=20
> Wouldn't writing this as `mode & (IDLE_WRITEBACK | HUGE_WRITEBACK)`
> be a bit easier to read as well as slightly more compact?

Scratch this comment, it just dawned on me that this is not an
equivalent expression, heh.

--=20
Cheers,
Joey Pabalinas

--p54u7efpquuy2ne2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv7+MUACgkQ2rGdfm9D
tVIIyw//fdicYFBla0D5Vw7v1nQsYwXaX05XdERBRp0wwxskAbL10GQSlp6ldhQY
Zi7n5o3/Y7HUnAfFGHkJh71GLrLORPoaz+ivrCJGcoolJbtxApXdL6g+LJrJBI1E
6lZdajBeRpDvabxUUtjLkYqe8DFfwIuo9IXYiy1ezxIHTaP+c0G7hBvM3YNnRzdY
Q2PhMM+c0INL0/SO6dxYABQaCBqqkY4YXgaeLA80FZ8Ga+390kGwIrAjffJ1DrNZ
kqozILnz596J9pfuGX05wgdr3iL0y5hzdXZTRUBiRxj/HBg34hutkcQkZk487vKb
bCDVQBs67PY08qjf3Dd82SB4iq1PYwy77+BgZIRB4yOASiaZyKif4yREIHqTYB19
BJtFPItr70ojGXteGErE6XnrU2Yl1B9jDvGf9awNGYsRRIgG+sV77b0sj1oEuxy5
6DmczBBu7j+CSwRggD5WyE4AFuqqEDCKNWMyOV8tQsiURKylzAZvt8AvMaHMgS2i
6WF603z0HCfMCIUzt6NjLtSO8Gsh9zizYV2ITYlqeaW5uIasMghA7kNa3GlonZW1
/ZiRuTudfOHdJTkP7p80oTFETY7DY8IOcOoEC7CUQKxiFvR8eWMDEPSktTnB8/T/
gl/8mxi5AZnZpnBPioMD1x6CufBrvkkBMCYd27O2Sq05kZ/ldSs=
=C8Fr
-----END PGP SIGNATURE-----

--p54u7efpquuy2ne2--