Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 14:30:28 +0000
From:   Charles Keepax <ckeepax@opensource.cirrus.com>
To:     Mark Brown <broonie@kernel.org>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH 3/3] gpio: Add reference counting for non-exclusive GPIOs
Message-ID: <20181126143028.GO16508@imbe.wolfsonmicro.main>
References: <20181122173015.23905-1-ckeepax@opensource.cirrus.com>
 <20181122173015.23905-3-ckeepax@opensource.cirrus.com>
 <CACRpkdZEu44WHScd5VibYT5C9RikqcvKsgpVOpkkdrYbLaV8Ng@mail.gmail.com>
 <20181123105729.GM16508@imbe.wolfsonmicro.main>
 <20181123132522.GE2089@sirena.org.uk>
 <20181126130001.GN16508@imbe.wolfsonmicro.main>
 <20181126140927.GD9715@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20181126140927.GD9715@sirena.org.uk>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 26, 2018 at 02:09:27PM +0000, Mark Brown wrote:
> On Mon, Nov 26, 2018 at 01:00:01PM +0000, Charles Keepax wrote:
> > On Fri, Nov 23, 2018 at 01:25:22PM +0000, Mark Brown wrote:
> 
> > > help the multiple users find each other somehow.  I think what we want
> > > to do here is either push the gpiod requests into the regulator core or
> > > change things so that once the regulator is registered with the
> > > regulator core the regulator core owns and is responsible for freeing
> > > the regulator.
> 
> > On the co-ordinating do we expect that the behaviour will
> > be that the GPIO should in the "enabled" state whenever any
> > regulator is requesting it? IE. the GPIO state is an OR of
> > the regulator states. Or are we expecting to handle more
> > complex interaction?
> 
> For the regulators that's what we do, yes - it's like they're all
> sharing a single regulator.  That probably won't be true in general for
> all GPIO users.

Would there perhaps be milage in looking at just making
the regulator core request the GPIO, rather than the end
drivers? Gives us a single request/free point. We don't need
any special flags in the GPIO layer, as its just a single
user as far as GPIO is concerned.

Thanks,
Charles