Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp24777imu; Mon, 26 Nov 2018 07:30:15 -0800 (PST) X-Google-Smtp-Source: AFSGD/WR+EBTiwhFfMlflVxONVS9aZ6fSGDgSnpu74ImQoqMgL0VNkvUsM+DKOuBFdpKmz6jXqYd X-Received: by 2002:a17:902:930b:: with SMTP id bc11mr28834460plb.17.1543246215184; Mon, 26 Nov 2018 07:30:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543246215; cv=none; d=google.com; s=arc-20160816; b=gL/uml4tLlpEjuhuaQDjrkqdpVsJq3uXKKxym5dRwwt8KfA+JxNQ0sTPj9SYKzmyoc y4lGDKE3iT/xHJIrwiPqGJxPOfgysAtQMg95rZ6KhDog9IHANzo2SZxZcngooirQ+7tq 6YaOPigDYjcKKCSU19Jk83GgA1biBfqDd4jhJaOcyzw9Ej8DfC2us94NEoU1tVXqVNDD 1QWPuhuaV8aGs9DZiUwcIBV9jOafzQmGzLQGxAqAy2zcb+SJ4tDSwbpfWfyg0RFmXLlK x218TTweJDjKZbAZlZDIKvpEqxoXSvaE2ImbaCWyqBfN31ABhC9CrM7zZgx5PTcVso8Q 0fZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NBLUnX9Ln4zBIu1JLoYtNPrzHSZvsnHChcK2EShpLeI=; b=XGR1ho3bbBcw6w2TxA1tdzcVl83YMtpk0Z6JP2+IxIT7QxS2eXrL48fVEPAToTZ6ZK hmYfKRAVMCH1u9LIrs+PXGPiaeT8P8LYT1QCVfe7JkWU91LKS9hP+nmlRpD+v2cbA4Jk j+d4wAXeNb6WPYspcmXGUNgbw5uALYmnZER5Quaqyxe8hWY0FSty23qnblbfAlLH9WfE 2lmch1niuG2uraoTdxYQ8tmWumtCRqoy3Ua1RivNNiPE0CUz2iq+n03lbE20C65tcDC6 c/d6gxTS1kH7vcETr6EFQ014Vc+12HSweo/iXgRNGsU2s1LnRWqaemztq5Hk8LlNc8Mt Sz+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@plaes.org header.s=mail header.b=JUDeyeuP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y21si618126pga.192.2018.11.26.07.29.49; Mon, 26 Nov 2018 07:30:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@plaes.org header.s=mail header.b=JUDeyeuP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbeK0CWp (ORCPT + 99 others); Mon, 26 Nov 2018 21:22:45 -0500 Received: from plaes.org ([188.166.43.21]:49992 "EHLO plaes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbeK0CWo (ORCPT ); Mon, 26 Nov 2018 21:22:44 -0500 Received: from localhost (85.253.196.132.cable.starman.ee [85.253.196.132]) by plaes.org (Postfix) with ESMTPSA id 0970041C64; Mon, 26 Nov 2018 15:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=plaes.org; s=mail; t=1543246095; bh=OUsll2pSZ+358NKNJxIvPOwFWCiSRmYw6WUlwJb5uoA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JUDeyeuPsJnifS/ateXI/uKf1+1hYIbC0VJnuf3ZPEugPFWQnUWo8XjIZ6vtuFesx XCSi6aN/qT4sQgUYGvLOcegxNnUELpkGUueu5XsqBd0MxG2xa+7LdwUMIrjL3Lj/hD duviv/2m4PHcT2pGDinQPj5Hmn7KD7mtet98ulCJ+P1YqziPO4I1hb8m66cjUv29dd +aWnYu2ygMNB11PARsm2U940A1Mf6Wm9MuKxB1Wirb/XCcDQv/iwSJewy0wYN6ubbR UbP98T9yFjdJKqRZiCkADXfEeXp0FxDtZnFMJ7KzHJqng14VGvLQXubM0y3vQqSSXJ 7VUeFl7KqW1tw== From: Priit Laes To: Lee Jones , Rob Herring , Mark Rutland , Chen-Yu Tsai , Maxime Ripard , Sebastian Reichel , Hans de Goede , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Cc: Priit Laes , Olliver Schinagl Subject: [PATCH 09/14] regulator: dts: add full voltage range to LDO4 on the Lime2 Date: Mon, 26 Nov 2018 17:27:50 +0200 Message-Id: <0b1aa5b28cb5efe17c04150a181ef1fa4027bc55.1543245984.git-series.plaes@plaes.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olliver Schinagl With commit b43776d65a33b46092 ("ARM: dts: sunxi: Use axp209.dtsi for Olinuxino Lime2") we force them an arbitrary 2.8 volts. Granted, for LDO3 this may be less arbitrary, but for LDO4 this is just wrong. In the defense of LDO3, LDO3 is the regulator that feeds port bank E, which has no other purpose then a CSI/TS interface, however the case may still be, that the connected IO may be just as well be 3.3 volts. The big misnomer is however, that the schematic names GPIO-2 pin4 LDO3_2.8V, rather then VDD-CSI0 or similar. This is much worse for LDO4 however, which is not referenced on any pin, is now set to 2.8 volts, but port bank G can also support various other peripherals such as UARTS etc. By having 2.8 volts however for LDO4, we thus now have peripherals that no longer function properly all of the time. Ideally, we want to set a supply voltage for each port bank, but the monolithic nature of the sunxi pinctroller currently prevents this and as such, the board should at least configure the LDO4 with the proper ranges. Until we can set the consumer at the port bank level, a child device-tree has to do something like: ®_ldo4 { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; While doing this the same way results in the same solution currently, we force the hack into the final devicetree rather then having it wrong at the board level. Signed-off-by: Olliver Schinagl Signed-off-by: Priit Laes --- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts index ffafe97..1b9867f 100644 --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts @@ -250,9 +250,10 @@ }; ®_ldo4 { - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <2800000>; - regulator-name = "vddio-csi1"; + regulator-always-on; + regulator-min-microvolt = <1250000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vdd-io-pg"; }; ®_usb0_vbus { -- git-series 0.9.1