Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp143963imu; Mon, 26 Nov 2018 09:01:25 -0800 (PST) X-Google-Smtp-Source: AFSGD/WB+hOgcTs+Ni9UrI1vivohc6db9lq7a/kJJWOFWWz6VjaHF48nGDNL1eZ3NuqROH40uc/S X-Received: by 2002:a63:4384:: with SMTP id q126mr25505194pga.160.1543251685831; Mon, 26 Nov 2018 09:01:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543251685; cv=none; d=google.com; s=arc-20160816; b=zEMs5yqENhpZPNhlQSEMPp74e4jBSwf6+/1v/ozJmy/ihWaidg56mw+kCA+5TlVgR4 8BtdTUKdaw8R9adT/PNYNqdUHoMzFzfs5yUs0fRYAtZSt0q9pc8PKuIJ+LjveKE0PdTa y3Q1sDFO0fmcUVG/MoRxBfAy5JqOtCAIpZemOgCueJVYvaeHphosnI8bucz2/jPA51Dj VOCNDJ/K6LZVIMd6dDhISIbBkpZdOkvVH7PwQLI+NcUcEo5dTATEVxEqjyBgK0u3inB1 Kw1KvsO8eBD3v9dvfp1/F72nBwhA/3LZcyJHaDcB8lVKuPPfkO+3YT2K2vCXvD1Cr0lb VqpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature; bh=yQjtGssgbxQcRF0LZljZqfmBmqvCvqekv+Xt07c7pFQ=; b=oDrGTNHrG4L9Q4aNxPthW6IGy2p6PaUlCR1nmmxcbdyt9xyJoviKxhwnKIw8qgSD0L X+tVc381IgjYeO0G6CvRqw0zwowM12CWdU1uE2f3Uu2iUpWkE5+Z8nwtjBunmdqc7/xc IY5CjTrhZHeFd8+M/ZXaWtocn43OlnxiXFJSeqDRHY7hGIGdf2JVK3XQY1RsE7tyj8xg R4GSG3J2qXAOyMJxHPiELNE5uwMNIH34TbyjUXHv5fSZsUMq0uNu8Xek0h5CRYVMkPw8 CrajtHdbuQtEMzHTiZ63+boJV74zV/X6GF2w+nSzIgUco7NuJpCWAaj1ePPhTy2AYj4u RG4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=M0CcvtjO; dkim=pass header.i=@codeaurora.org header.s=default header.b=D0QIr8Nz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1-v6si780703plb.303.2018.11.26.09.00.31; Mon, 26 Nov 2018 09:01:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=M0CcvtjO; dkim=pass header.i=@codeaurora.org header.s=default header.b=D0QIr8Nz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbeK0Dxk (ORCPT + 99 others); Mon, 26 Nov 2018 22:53:40 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33308 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbeK0Dxk (ORCPT ); Mon, 26 Nov 2018 22:53:40 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2115760B13; Mon, 26 Nov 2018 16:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543251538; bh=ZH8wN3/Y4aVblhi1bxQS0XI+pHl4m+rKtKEsQAw2H+g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M0CcvtjOlUFE441i20KkkXBmOP1hOrhV8GPt6ndcMx5+FpTe98kVpSR35vyJ627XU YMFDb5HRPwVM/8eWaHFR3icKSLc9lIUlYFpH3Lj7S+/jrfeE8ce/25UZRA2MZP5hvq zqzRf1+gNaZcJ8wQpcfjWjxHuslhYKDPTaBDKEN8= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 1302A6079C; Mon, 26 Nov 2018 16:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543251537; bh=ZH8wN3/Y4aVblhi1bxQS0XI+pHl4m+rKtKEsQAw2H+g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D0QIr8Nz07MILpxVCflV7byejELUzLmvcwcbXmKgO0ouFIx5Hj/cWZt4mTTAOb6Jg OuQCG6ddKMg0K+lNIkquHTjTyaGc/9xYwhrkYD8Nu8ShR5EJ8TkZ/SI38EGllGfhvN JR0UG9P5Aq0nznpVRuOYyyzXGfGTqfVctj1M5oFc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Nov 2018 22:28:57 +0530 From: Govind Singh To: Vinod Koul Cc: andy.gross@linaro.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node In-Reply-To: <20181126144422.GU3175@vkoul-mobl.Dlink> References: <20181126142133.16966-1-govinds@codeaurora.org> <20181126144422.GU3175@vkoul-mobl.Dlink> Message-ID: X-Sender: govinds@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, Thanks for the review. On 2018-11-26 20:14, Vinod Koul wrote: > Hi Govind, > > On 26-11-18, 19:51, Govind Singh wrote: >> Add device node for the ath10k SNOC platform driver probe >> and add resources required for WCN3990 on qcs404 soc. >> Optional clock and regulator controls are not yet available in >> upstream, hence add them once available. >> >> Signed-off-by: Govind Singh >> --- >> arch/arm64/boot/dts/qcom/qcs404.dtsi | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi >> b/arch/arm64/boot/dts/qcom/qcs404.dtsi >> index 9ca4f061ecc5..1a401a32d4a1 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi >> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi >> @@ -958,6 +958,25 @@ >> status = "disabled"; >> }; >> }; >> + >> + wifi: wifi@0A000000 { > > Please remove leading 0 from node > Sure, i will change in v2. >> + compatible = "qcom,wcn3990-wifi"; >> + reg = <0x0A000000 0x800000>; >> + reg-names = "membase"; >> + memory-region = <&wlan_msa_mem>; >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + }; >> }; >> >> timer { > > This file is sorted alphabetically and reg values. So this should be > between blsp1_uart2 and intc node, can you please change that > > Also please compile this with W=12 > Sure, i will change in v2. > Lastly, I am not sure, but should the wifi node be always enabled? > Should it not be enabled in the board dts file? Bjorn..? > yes, i some how missed this. I will mark the status disabled by default and enable from qcs404 evb dts. > Thanks