Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 12:18:36 -0500
From:   Sasha Levin <sashal@kernel.org>
To:     Matt Hart <matthew.hart@linaro.org>
Cc:     boris.brezillon@bootlin.com,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        gregkh@linuxfoundation.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org, nicolas.ferre@microchip.com,
        rainyfeeling@outlook.com, johan@kernel.org
Subject: Re: [PATCH 4.14 58/62] mtd: rawnand: atmel: fix OF child-node lookup
Message-ID: <20181126171836.GB100860@sasha-vm>
References: <20181126105050.592727680@linuxfoundation.org>
 <20181126105054.941598787@linuxfoundation.org>
 <CA+G9fYsyM9VS8QkaEizQT_LSvZyT+h6zdoWZbhVQtd1n60Bniw@mail.gmail.com>
 <20181126160840.1c702e87@bbrezillon>
 <20181126151601.GA100860@sasha-vm>
 <CAH+k93GJjYB75Z+zkrzdkbabUaTSzWCfLGXuuVRuu8ML=6yY6g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAH+k93GJjYB75Z+zkrzdkbabUaTSzWCfLGXuuVRuu8ML=6yY6g@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 26, 2018 at 04:39:03PM +0000, Matt Hart wrote:
>On Mon, 26 Nov 2018 at 15:16, Sasha Levin <sashal@kernel.org> wrote:
>>
><snip>
>
>> >>
>> >> /drivers/mtd/nand/atmel/nand-controller.c: In function
>> >> 'atmel_hsmc_nand_controller_legacy_init':
>> >> /drivers/mtd/nand/atmel/nand-controller.c:2080:11: error: implicit
>> >> declaration of function 'of_get_compatible_child'; did you mean
>> >> 'of_get_next_available_child'? [-Werror=implicit-function-declaration]
>> >>    nfc_np = of_get_compatible_child(dev->of_node, "atmel,sama5d3-nfc");
>> >
>> >Looks like of_get_compatible_child() has been introduced in 4.18, hence
>> >this error.
>> >
>> >Greg, can you drop this patch from 4.14.y?
>>
>> Interesting, none of the kernelci builds caught this? hmm
>
>They did, a few arm defconfigs failed to build because of this error.
>https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.83-64-gd81d0be7d560/

Indeed, and it was even removed from a few (but not all) of the branches
it failed on. I retract my kernelci comments :)

--
Thanks,
Sasha