Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\))
Subject: Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
From:   Josh Elsasser <jelsasser@appneta.com>
In-Reply-To: <87efb92z5w.fsf@miraculix.mork.no>
Date:   Mon, 26 Nov 2018 09:54:28 -0800
Cc:     intel-wired-lan@lists.osuosl.org,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <40FD0CE5-973C-4A7F-91BD-66C1A1699223@appneta.com>
References: <20181124205801.67828-1-jelsasser@appneta.com>
 <87efb92z5w.fsf@miraculix.mork.no>
To:     =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Bj=C3=B8rn Mork <bjorn@mork.no> wrote:

> Not that it matters much I guess, but I think LX SFPs were unsupported
> at that time. The LX support appears to have been added under the =
radar
> while refactoring ixgbe_setup_sfp_modules_X550em in commit =
e23f33367882
> ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")

Looks like you=E2=80=99re right. Want me to respin with an additional =
=E2=80=9CFixes=E2=80=9D tag?

- Josh=