Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp310389imu; Mon, 26 Nov 2018 11:12:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/V+Ib92aEhXVjmw8dl7uQ99klxgrquy4YtGBXv82UaM5UvR5eMFQPopSiHiNH2lxieSqV3L X-Received: by 2002:a63:9c1a:: with SMTP id f26mr26370648pge.381.1543259553793; Mon, 26 Nov 2018 11:12:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543259553; cv=none; d=google.com; s=arc-20160816; b=ozfObXPq4aF4WGd83ygotHVDRwaTubtMKioFhbA9GNZj9JiOpoODTOFgLdlfjY0aG2 BGPb+5NJcrIsNl/e9Q8FgcKZw7Z1Bd7yTg6ddjr4d1dDnX7XKCJUMoTZsdWv85JYWVRh Zqaw34ZGbW67EtErOYFieWhUIWgFjN41hB1yVjxFonBY+H228aPEYLXdGXAt6TsVn7z/ Q6WwbJchZ3cimt9Yh7HURXwo1QTdytq6oNrEl+G32m9Xj7ZH9QG14/Ui7KRJVr17ciR9 D91QHDzwjQXVlT2hRoltcmLr+XqqVsI6lRtZQUJyMMBrbPsVimW1T3OA/lKqHc7Mo9k5 tmqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=b/I598pTjfrPvsnIzBe+YuIgZ+knih3xlc4TkqLrPxE=; b=eDFpTZhFGU/dd7a2EjdrP4Me8c+lyoHfQYPDZdh/RFkJT9gFh9rc4JrEXu1L+KoQM1 vEymzsva01n1ylItZOVRTMhbzwvP2wSi76hEUtnQV+R+IBEE2bNBvEAj/qJ/VluNPCkl PiAdyvF/bvFs8gLdEB/HwG1eFWXVKjK6ceJ1ceBHX0fiRo6AFGiosgtEiqH96885+uRH e4wfPy+MfBCymx43Lhg3aQb8qzzP80pwhYE6a8+DcTPxtMcEPqut63Vw+QDYS5zUphny 3KoE2fgAZr7RgUffdYr+q5POuBM3gToBwdlXPQFu/s1WJ7Tsexxn8fgqwvDpDhpu6K72 BW+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si1038107pgm.296.2018.11.26.11.11.56; Mon, 26 Nov 2018 11:12:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbeK0GEL convert rfc822-to-8bit (ORCPT + 99 others); Tue, 27 Nov 2018 01:04:11 -0500 Received: from mail.bootlin.com ([62.4.15.54]:40202 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbeK0GEL (ORCPT ); Tue, 27 Nov 2018 01:04:11 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 4489A20711; Mon, 26 Nov 2018 20:09:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from bbrezillon (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 9AA6D20D2E; Mon, 26 Nov 2018 20:08:55 +0100 (CET) Date: Mon, 26 Nov 2018 20:08:55 +0100 From: Boris Brezillon To: vitor Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts Message-ID: <20181126200855.0caa45b0@bbrezillon> In-Reply-To: <20181126195618.352eafb1@bbrezillon> References: <20181122210202.6af50fcc@bbrezillon> <6d513e04-3a57-1989-429c-64631101c5a2@synopsys.com> <20181123135004.7fd1cd58@bbrezillon> <83115f47-1326-cb33-a7dc-4bc8ff95befa@synopsys.com> <20181126133550.51469816@bbrezillon> <4e9c0461-02a3-80b2-c9b7-2e9ea9b38f8b@synopsys.com> <20181126195618.352eafb1@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Nov 2018 19:56:18 +0100 Boris Brezillon wrote: > > > >     - for the others it will easy the SoC integration avoiding > > duplicated work and doing things from scratch. > > What would be duplicated? You want to support a new SoC, just add a new > entry in the of_match_table and you're done. When you need to add > SoC/integration specific stuff, create a struct and attach a different > instance per-compatible so that each SoC can have its own configuration > (or even init sequence if needed). That's how we do for pretty much all > IPs out there, why should designware ones be different? To be more specific, I'd like a real example that shows why the separation is needed.