Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181121031449.255314-1-schuffelen@google.com> <d0ba9821e46e1111bc483188466bb68dc1bb3c4a.camel@sipsolutions.net>
In-Reply-To: <d0ba9821e46e1111bc483188466bb68dc1bb3c4a.camel@sipsolutions.net>
From:   Cody Schuffelen <schuffelen@google.com>
Date:   Mon, 26 Nov 2018 11:52:27 -0800
Message-ID: <CAAELVAEVJK3iezPVCB9fizDwy+HoFtFZp5KTMDu+GmYCy-KG1A@mail.gmail.com>
Subject: Re: [PATCH mac80211-next v4] mac80211-next: rtnetlink wifi simulation device
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        sergey.matyukevich.os@quantenna.com, linux-kernel@vger.kernel.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        kernel-team@android.com, Alistair Strachan <astrachan@google.com>,
        Greg Hartman <ghartman@google.com>,
        Tristan Muntsinger <muntsinger@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > +config VIRT_WIFI
> > +     bool "Wifi wrapper for ethernet drivers"
>
> The built bot complaint is most likely because of this being bool rather
> than tristate (CFG80211=m, VIRT_WIFI=y, I guess, didn't check), I
> thought this was because of the wrong reasons and should be back to
> tristate?
>
> I can change it back, let me know.
>
> johannes

Right, my mistake. This should be a tristate again, sorry about that.
Should I send v5 for this?

Cody