Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
To:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc:     Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Subject: [PATCH RESEND] tty/sysrq: Do not call sync directly from sysrq_do_reset()
Date:   Tue, 27 Nov 2018 09:57:23 +1300
Message-Id: <20181126205723.14478-1-mark.tomlinson@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

sysrq_do_reset() is called in softirq context, so it cannot call
sync() directly. Instead, call orderly_reboot(), which creates a work
item to run /sbin/reboot, or do emergency_sync and restart if the
command fails.

Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
---
=20drivers/tty/sysrq.c | 3 +--
=201 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index ad1ee5d01b53..f2ca32c1ad7c 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -660,8 +660,7 @@ static void sysrq_do_reset(struct timer_list *t)
=20
=20	state->reset_requested =3D true;
=20
-	ksys_sync();
-	kernel_restart(NULL);
+	orderly_reboot();
=20}
=20
=20static void sysrq_handle_reset_request(struct sysrq_state *state)
--=20
2.19.2