Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 11:18:35 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     David CARLIER <devnexen@gmail.com>
Cc:     joeypabalinas@gmail.com, linux-kernel@vger.kernel.org,
        alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org,
        andriy.shevchenko@linux.intel.com, aryabinin@virtuozzo.com
Subject: Re: Re: [PATCH] Little memset_explicit optimisation
Message-ID: <20181126211835.wdqiqszz6u65cbe3@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        David CARLIER <devnexen@gmail.com>, linux-kernel@vger.kernel.org,
        alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org,
        andriy.shevchenko@linux.intel.com, aryabinin@virtuozzo.com
References: <CA+XhMqyR1wMEnEE2cCnoGj2RatxTbFuNH2jOj1-50iYso67rAw@mail.gmail.com>
 <20181126113724.svbv6np25fzxkhrm@gmail.com>
 <CA+XhMqz9igfiZqRgwvfQ0c=FVyWf=ZUD0xjypEgzO27qwmBNeA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5p7fgi77jkdtgm5h"
Content-Disposition: inline
In-Reply-To: <CA+XhMqz9igfiZqRgwvfQ0c=FVyWf=ZUD0xjypEgzO27qwmBNeA@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--5p7fgi77jkdtgm5h
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 26, 2018 at 07:36:19PM +0000, David CARLIER wrote:
> Sorry I m not used yet at all to LKML rules.
>=20
> So here a slight difference in assembly generated between the two
> versions (amd64) :
> `
>      .loc 1 7 7
>      leaq    -12(%rbp), %rax
>      movq    %rax, -8(%rbp)
> -    .loc 1 11 2
> +    .loc 1 9 6
>      movq    -8(%rbp), %rax
>      movl    $4, %edx
>      movl    $0, %esi
>      movq    %rax, %rdi
>      call    memset@PLT
> +    movq    %rax, -8(%rbp)
>      .loc 1 13 23
>      movq    -8(%rbp), %rax
>      movl    (%rax), %eax

What is the advantage of having the added `movq %rax, -8(%rbp)` here?

The next instruction is `movq -8(%rbp), %rax` and nothing afterwords
uses the value stored in `-8(%rbp)`.

Also, is this compiled without optimization? Take a looks at the
assembly in a small test case with -O1 (making sure to use the target
variable so it isn't optimized out) and compare the assembly generated
with and without that assignment.

--=20
Cheers,
Joey Pabalinas

--5p7fgi77jkdtgm5h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv8YysACgkQ2rGdfm9D
tVKATw//Wwix4UmSG5SKowfLzD/VHgJ0WVGXQO7xd1K5npqdp2+jWZmeL7EQxB8U
zl4obOxOk83h54YXLxYy3AQhzo/jpBDQAypL039YErjE4G21ERvAs6oltOuKqrOI
VMOTM4C57iKhEYw8ZcRoOMmDNZmD8Q6fD6pkf2krfQcZe/v6qdSasaVbJXZ1PrNt
1JhUjLWHnHDWHSqM6erDiYRKjAqF/VsEzRkYDX6O8vpA4ckxJ4xe07cSd5XE4kjN
i1JSvV1mwv4Ed18GAkkRuvfKPo5wyLTdrWMYORXc22zUB2WmuGOA1cUm3Qrt6bcM
Uz7q316Lk5EFcwTU6EOxSmmVIKm6gcvaOzBxcCuq4ERimyQZ5sxoPYWBquQ7mapC
mMqTU8hh06hMTFeSec+AdOld1GTYF7W1gW/edkHXFJIL3KLlKNeC9lS4xx7I1C6z
puqKP+JViKUXBOpvFyN6WqNbbXfa1sU0f8F0sLuQYK5UCHnv+M7IvQS6JYWJpgnu
qyJMgh6v3ocvwj8sVB0p33MAIaC7paMvu23p8BtxTs0MdNLuAP4fCj+qQ+DmMIQ3
WTF7SLjKJJPPxMm7QBSlqIxbCnkhdj5W0PkSk4qixSp680iRM5p3jT1z2x6Db1Be
10KT10qKsIJjYCxWv7nvZpjplmmA5LnES0gicASfnCI6Za8b5Xs=
=0nC3
-----END PGP SIGNATURE-----

--5p7fgi77jkdtgm5h--