Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 11:37:15 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Joey Pabalinas <joeypabalinas@gmail.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Andy Lutomirski <luto@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: Re: [RFC][PATCH 08/14] function_graph: Remove unused
 task_curr_ret_stack()
Message-ID: <20181126213715.s2bn3wztxqikee35@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Andy Lutomirski <luto@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
References: <20181122012708.491151844@goodmis.org>
 <20181122012803.706044851@goodmis.org>
 <20181126100207.3kcu2ej5eoxzubqq@gmail.com>
 <20181126162750.500a7dbd@gandalf.local.home>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="d65uo5mk5fmomzrh"
Content-Disposition: inline
In-Reply-To: <20181126162750.500a7dbd@gandalf.local.home>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--d65uo5mk5fmomzrh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 26, 2018 at 04:27:50PM -0500, Steven Rostedt wrote:
> On Mon, 26 Nov 2018 00:02:07 -1000
> Joey Pabalinas <joeypabalinas@gmail.com> wrote:
>=20
> > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote:
> > > The static inline function task_curr_ret_stack() is unused, remove it=
=2E =20
> >=20
> > Just want ot make sure I understand this correctly, instead of using th=
is
> > function, the convention now is to just directly assign `t->curr_ret_st=
ack =3D -1`?
> >=20
>=20
> Not sure what you mean. This function would just return the value of
> curr_ret_stack, it didn't modify it.
>=20
> -- Steve

Sorry for wording it a bit weird, I was mostly trying to figure out what
these functions were originally used for. The uses I found in the git
log were mostly things like:

	ret =3D trace_vprintk(ip, task_curr_ret_stack(current), fmt, ap);

I guess the 2nd argument for these trace functions are implicit now and
these functions are no longer needed anywhere?

--=20
Cheers,
Joey Pabalinas

--d65uo5mk5fmomzrh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv8Z4oACgkQ2rGdfm9D
tVK0BhAA2GbW7eXXtwN3wIz4qF4gUrXpUZ5fGXcWp7tn+nOaNlvLpmQ/0GpYU09D
trJhFqspht+8dAv95Y5I1Eajfo3n/fDP5snaggI2fNfWUBG5nS947SsI8L5hwIUW
fMFGHjO4xYzkGMBxa2bR4MyG2ObyYXsVjGoGrHdYXA5mmDfqIlnDb5XJL3cTPw5Y
ze45/kBGxhSojsDnwbKmfqprub9bHv3Jb16/QvOvwZuMAwem9qfppkCC8K9hif/s
bW6lZLXc30WJOsQM8/VX3Ld4s2KfpBYR1XmdJcrieveEaB/ywe74F1lq+lAnfgdq
3wNTNNmLndQ4hqfMNQjQiNpvlLybcIKta46y1Kx5SLNKCvLDaW+rAwlmmCnV99DG
34XLXCasalsw7oIvYMgXLKg/IPoMh/+sRZquLHTCeZwc18u7FWdFbyNoA0EbLg9f
2ggTR/kP7eBTVIN7cTEGWN1x5lznCO1zAMfzP0EP9yqdulcBQBoSbxXBqJJ8mS+c
bwycRVu4IY75Wyw/XRNmZ9p0+PkjwDEKdOi2ZhWpppa+ISREEukzltG3/nIDGkPA
6BCY1tWSrNubBA9gs9DwUPo7+ng08REPRq58hiPb4dIM1h7S+8WbmcJqwc1KZiq9
OqE3h4dxFJY5wVCV659TDtd7vZnt1csiI8XodiudAdXm1LibRmY=
=nyIq
-----END PGP SIGNATURE-----

--d65uo5mk5fmomzrh--