Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: linux-next: build warning after merge of the f2fs tree
To:     Jaegeuk Kim <jaegeuk@kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Kees Cook <keescook@google.com>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20181126111933.1b0fb324@canb.auug.org.au>
 <20181126215924.GA55960@jaegeuk-macbookpro.roam.corp.google.com>
 <20181127091747.4830d123@canb.auug.org.au>
 <20181126222257.GB55960@jaegeuk-macbookpro.roam.corp.google.com>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <37611a15-da14-1796-5f4c-1278d46a4329@embeddedor.com>
Date:   Mon, 26 Nov 2018 16:36:36 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181126222257.GB55960@jaegeuk-macbookpro.roam.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/26/18 4:22 PM, Jaegeuk Kim wrote:
> On 11/27, Stephen Rothwell wrote:
[..]
> 
> Oh, thanks~
> Is this okay?
> 

Yep. This fix the warning. :)

Thanks, Jaegeuk
--
Gustavo

>  From 79e24f1509e5b6a07069be9cc8163969da78c57a Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk@kernel.org>
> Date: Mon, 26 Nov 2018 14:20:32 -0800
> Subject: [PATCH] f2fs: avoid build warn of fall_through
> 
> After merging the f2fs tree, today's linux-next build
>   (x86_64_allmodconfig) produced this warning:
> 
>   In file included from fs/f2fs/dir.c:11:
>   fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
>   fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>      if (set)
>         ^
>   fs/f2fs/f2fs.h:2390:2: note: here
>     case FI_DATA_EXIST:
>     ^~~~
> 
>   Exposed by my use of -Wimplicit-fallthrough
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>   fs/f2fs/f2fs.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 26ad1de8641c..b3fe6803d4c6 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
>   	case FI_NEW_INODE:
>   		if (set)
>   			return;
> +		/* fall through */
>   	case FI_DATA_EXIST:
>   	case FI_INLINE_DOTS:
>   	case FI_PIN_FILE:
>