Date: Wed, 14 Jan 2004 00:49:44 -0800
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@muc.de>
Cc: jh@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compilation on gcc 3.4
Message-Id: <20040114004944.5ba6b4a5.akpm@osdl.org>
In-Reply-To: <20040114083700.GA1820@averell>
References: <20040114083700.GA1820@averell>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 981
Lines: 25

Andi Kleen <ak@muc.de> wrote:
>
> 
> The upcomming gcc 3.4 has a new inlining algorithm which sometimes
> fails to inline some "dumb" inlines in the kernel. This sometimes leads
> to undefined symbols while linking.

That's a compiler bug, surely.

> To make the kernel compile again this patch drops the always inline
> for gcc 3.4.  The new algorithm should be good enough to do the right
> thing on its own. 

Are you sure?  Without the always_inline stuff we were seeing 100 different
copies of __constant_c_and_count_memset and friends in the vmlinux symbol
table.  It was really silly.

After applying this patch and building with gcc-3.4, how does `size
vmlinux' compare with the same kernel built with gcc-3.3, minus the patch?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/