Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Nov 2018 04:44:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Cristian Sicilia <sicilia.cristian@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Carmeli Tamir <carmeli.tamir@gmail.com>,
        Christopher Diaz Riveros <chrisadr@gentoo.org>,
        Arkadiusz Lis <areklis909@gmail.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: emxx_udc: Added a temporary variable with
 address.
Message-ID: <20181127014458.GN2970@unbuntlaptop>
References: <1543274351-25762-1-git-send-email-sicilia.cristian@gmail.com>
 <1543274351-25762-3-git-send-email-sicilia.cristian@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1543274351-25762-3-git-send-email-sicilia.cristian@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 27, 2018 at 12:19:09AM +0100, Cristian Sicilia wrote:
> Replace the IO_ADDRESS call with a temporary variable.
> 
> Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index ebc622f..d55cadd 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -108,20 +108,22 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
>  
>  	dev_dbg(&udc->dev, "\n-USB REG-\n");
>  	for (i = 0x0 ; i < USB_BASE_SIZE ; i += 16) {
> -		reg_data =   _nbu2ss_readl(
> -			(u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i));
> +		u32 *tmp;
> +
> +		tmp = (u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i);
> +		reg_data = _nbu2ss_readl(tmp);


What problem are you trying to solve?  Shouldn't it just be:

		reg_data = _nbu2ss_readl(IO_ADDRESS(USB_BASE_ADDRESS + i));

regards,
dan carpenter