Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp144765imu; Mon, 26 Nov 2018 18:27:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/XjEgyMLWNlZ9UvMMo9y/C5NsgzW9RPf0L20WdnnHXkAeCONIQ3vzw+Bw99Pfa+lkRy6dpJ X-Received: by 2002:a63:d047:: with SMTP id s7mr27270187pgi.311.1543285674191; Mon, 26 Nov 2018 18:27:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543285674; cv=none; d=google.com; s=arc-20160816; b=Oh2j+eCUHc5bXURorDO0XefLuugdXc3320jp3sKBBkZcW5Wo0MDNO2Rsn43j0Y70VK Z/EzuRcEEYW38Vj5+JKeGy5M37CeD10Bffy83NsXRE0zk/nYSiOJFo6sUUo2e4T7kn6x p7PtEU1ZtEe7qRdyV4wded/uU+YKYSZAhCS0xd0s8SSMMVhjtrYfCDhMrEw/Dqt6uG/d xJ/txMhNmTWD5FhD7nEAxp785dPajsxSBxv76/zzAl8daHgfw11GiC5/yazU+YFYY15Q CgDmnjXUOAFCsiRHmfPPOpCS9HJkG25XhC0xMe9P8HlpQ4wQOlyWHiAk3BhKEUe6+z0o XhjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=iYxleyOIyKlSE6MIpkrFPFa7KIgX5NLDfd4gLAY0Gh8=; b=b4YSu5kYDg/s6Cwe7Sd7MqmHzbNybB0JW7uz+/9vEcs201gq2UvNnWMsllvqqb+xLb gOICOLmm9ue0bABfFbfVv9z1Pm7DQzw0oTblBVbkIDvinMc4a1EBrotlXwRPuy/CizDa GRIYzUs2rELmRPBqoX14InQiJP6J7b084bbWJGGwol5j5l0rw1HehTeBjcTzW1x/mzt9 knPtPM4sdh/AvELLfG9yphhf6sZNbmH3wueAmEWt+WKH7TxoZxjibU05yat2swsQuCT5 5kPmnmMnbqt79l6NGwwDYkhAoYsJpDo+ZLdvJ14cM28YYhvr0c7aIl/fJ2EhGioRjTks 98nQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si2404074plk.373.2018.11.26.18.27.38; Mon, 26 Nov 2018 18:27:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728277AbeK0NWC (ORCPT + 99 others); Tue, 27 Nov 2018 08:22:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33828 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727625AbeK0NWC (ORCPT ); Tue, 27 Nov 2018 08:22:02 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BC803002E12; Tue, 27 Nov 2018 02:25:45 +0000 (UTC) Received: from ming.t460p (ovpn-8-29.pek2.redhat.com [10.72.8.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23A1B5C6DC; Tue, 27 Nov 2018 02:25:23 +0000 (UTC) Date: Tue, 27 Nov 2018 10:25:19 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V12 16/20] block: enable multipage bvecs Message-ID: <20181127022517.GC25199@ming.t460p> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-17-ming.lei@redhat.com> <20181126125842.GE6383@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126125842.GE6383@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 27 Nov 2018 02:25:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 26, 2018 at 01:58:42PM +0100, Christoph Hellwig wrote: > > + phys_addr_t vec_end_addr = page_to_phys(bv->bv_page) + > > + bv->bv_offset + bv->bv_len; > > The name is a little confusing, as the real end addr would be -1. Maybe > throw the -1 in here, and adjust for it in the contigous check below? Yeah, it makes sense. thanks, Ming