Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Nov 2018 16:53:32 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Minchan Kim <minchan@kernel.org>
Cc:     Joey Pabalinas <joeypabalinas@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v2 5/7] zram: support idle/huge page writeback
Message-ID: <20181127025332.23wlp4zai6e7mrip@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Minchan Kim <minchan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
References: <20181126082813.81977-1-minchan@kernel.org>
 <20181126082813.81977-6-minchan@kernel.org>
 <20181126094737.sfudpeoigra2vir7@gmail.com>
 <20181127021327.GD237537@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uww5br4pqkvqqwfq"
Content-Disposition: inline
In-Reply-To: <20181127021327.GD237537@google.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--uww5br4pqkvqqwfq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 27, 2018 at 11:13:27AM +0900, Minchan Kim wrote:
> On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote:
> > On Mon, Nov 26, 2018 at 05:28:11PM +0900, Minchan Kim wrote:
> > > +	strlcpy(mode_buf, buf, sizeof(mode_buf));
> > > +	/* ignore trailing newline */
> > > +	sz =3D strlen(mode_buf);
> >=20
> > One possible idea would be to use strscpy() instead and directly assign
> > the return value to sz, avoiding an extra strlen() call (though you wou=
ld
> > have to check if `sz =3D=3D -E2BIG` and do `sz =3D sizeof(mode_buf) - 1=
` in that
> > case).
>=20
> Thanks for the suggstion.
> If I limit destination buffer smaller, I couldn't meet -E2BIG?

-E2BIG return from strscpy() just means the string was longer than would
fit in the length passed as the third argument. This means only
`sizeof(mode_buf) - 1` bytes were copied into the dest, with the last
byte being the \0 terminator.

You can find the function source in lib/string.c.

> > > +	ret =3D len;
> > > +	 __free_page(page);
> > > +release_init_lock:
> > > +	up_read(&zram->init_lock);
> > > +	return ret;
> >=20
> > Hm, I noticed that this function either returns an error or just the pa=
ssed
> > in len on success, and I'm left wondering if there might be other useful
> > information which could be passed back to the caller instead. I can't
> > immediately think of any such information, though, so it's possible I'm
> > just daydreaming :)
>=20
> It is write syscall semantic of sysfs so not sure it's doable to pass
> other value to user.

Well, with the write system call you can have partial writes, in which
case it would return the (short) number of bytes written. But in this
function, even if there was some sort of partial write possible, this
function still only every returns len or error.

Neither of these are that important though, so Ack from me with or
without these two suggestions.

Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>

--=20
Cheers,
Joey Pabalinas

--uww5br4pqkvqqwfq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv8sasACgkQ2rGdfm9D
tVKQwxAAl57Z+TFCh/x3f1sz0/UKSIYwTb3uqnyl7jv2FHK+ZVPeGwggSK2yeAFY
uRIizMH23LKGMTeMSeJ1mE8F+GUvy0HeizzGR475phJH3qPgvzXk3qj3m1UK3aBS
3uEZogQcg5vjKsbICEFhb30vvhpPplM/YIFvzzzW2oRxe5vz5/bHGZ20wA2uHSCS
WXAu8SmMxjB/n3+tPHLdTeHCO7Y2rYCt+c8MSlAGo2j0iz/9OH0u4kX5WRqy0A6m
qo8oI2WoyjauwJgqL+tnqs3Q15AQySd4FU8YQ1Ro9mldyUDydNYncCv1QNuqdv6u
1jzyPSLyelOEl7eMMPiESI+1ZdptgH3wRitPmDHv9+CIs3srsmJH8NJlXkI8FO+y
zZuuJeyF9k5YbNLt2FMSGG/v2OcuGSaNIr1NnL7H6p2X7+c5Bnwgl2rH4smvJmDK
tB537x4GvDy3kEo3x7ZNXFMwFkbFhwXJcu6IViglHe14+u9oKpALF8n6Kwa9iW2s
k5LkU0CzbvrghyL8BvZiiszxjHpGV8dBmHKOd6dtCju8O/aCNKX6jtDSdxSMwMoL
k6pH1NcqpFHRjVl9HxpymdLhId+7QAlrPiFnyy7mHNoduzV7X/H97u5R01/YVVPU
vwNlrrWNRzZAJsEA/7q8zAHGNlAG+Up2HWDHJQijRB4H1/a2M9g=
=EgsN
-----END PGP SIGNATURE-----

--uww5br4pqkvqqwfq--