Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp347381imu; Mon, 26 Nov 2018 22:53:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/U9xLuptDb579DRRkO8DOYuynMH9hRYXf1pEGnFIETaQNSDTjSaZHG3pHrjCeS5J4PkBzgB X-Received: by 2002:a63:374e:: with SMTP id g14mr28560339pgn.59.1543301607169; Mon, 26 Nov 2018 22:53:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543301607; cv=none; d=google.com; s=arc-20160816; b=xqgXP2uZbKYNGjOhQ5w+DXcbSDXLUd1e+YSB4PPpDbXOw1b8f6mMglfmLcyipzNIaq lYQLG1dwb7aV+vrCqLggwKtm8q0cWMmAz+jAAfFgLIdZ0yrfm/PwKH5t4OBJRVW3ptg1 vDa8mkr8+kgr0p+JTHoG8FbHso75Wm/mmIEiEzGZganHc7IPPbB5XbWLdg9mrghggaab t6mYgQ03C8c7V/9T7gbUo7srvJJdUBdcTFxsdnIzzdN6JuAGjflv+Z/ijarK022c4QjC 4Bk8QsJhB0eZV2vVCy4K+W4AEkpap1/RMzbpXgpGf1v3m/Gjpj0h3qDDseC/Of/hUL0J J/6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=rhqwji/N6wxZb5r7XPOagZgxdutwOSUsWmtqzMc03kQ=; b=oHYtSenwQ6+nc7okUSQ2xKa+ZpYQf6AHZ2uluVvZmrDQr4M96ACs8KgWAJD0lOPG68 +KzqRVyS5aKJ6ZFdm1P7XI7kkf6rpGp+nIlHgrWLAHBrGJmsAYDBfXwHSmGqSUBGVZWa aMUvy7IQHQcCAtcjfcHnK5H++9YsdjvVH9AVevycINhM4413VIQ5BSt7Gs/1LNAUlF7h oirfVx7yweDmmSouh6xWuVH7GUDo0cAfRSYhV0d4Y9Wtm6BwHlBvQNXya4T3hYTe7O+E T3pGSf6tmvsBW0El5LnCyGIIU9o0xrT3B5T4RtnoLalwqwE8k3uIq54W/oRUR2+jaz+C 4u3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si3309236pfq.56.2018.11.26.22.53.11; Mon, 26 Nov 2018 22:53:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728758AbeK0ROx (ORCPT + 99 others); Tue, 27 Nov 2018 12:14:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53484 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727331AbeK0ROx (ORCPT ); Tue, 27 Nov 2018 12:14:53 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0180E14E0F702; Mon, 26 Nov 2018 22:18:04 -0800 (PST) Date: Mon, 26 Nov 2018 22:18:04 -0800 (PST) Message-Id: <20181126.221804.911097813637187592.davem@davemloft.net> To: mst@redhat.com Cc: tiwei.bie@intel.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtio-dev@lists.oasis-open.org, wexu@redhat.com, jfreimann@redhat.com, maxime.coquelin@redhat.com Subject: Re: [PATCH net-next v3 00/13] virtio: support packed ring From: David Miller In-Reply-To: <20181127010157-mutt-send-email-mst@kernel.org> References: <20181121100330.24846-1-tiwei.bie@intel.com> <20181127010157-mutt-send-email-mst@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 26 Nov 2018 22:18:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Tue, 27 Nov 2018 01:08:08 -0500 > On Wed, Nov 21, 2018 at 06:03:17PM +0800, Tiwei Bie wrote: >> Hi, >> >> This patch set implements packed ring support in virtio driver. >> >> A performance test between pktgen (pktgen_sample03_burst_single_flow.sh) >> and DPDK vhost (testpmd/rxonly/vhost-PMD) has been done, I saw >> ~30% performance gain in packed ring in this case. >> >> To make this patch set work with below patch set for vhost, >> some hacks are needed to set the _F_NEXT flag in indirect >> descriptors (this should be fixed in vhost): >> >> https://lkml.org/lkml/2018/7/3/33 > > I went over it and I think it's correct spec-wise. > > I have some ideas for enhancements but let's start > with getting this stuff merged first. > > Acked-by: Michael S. Tsirkin Series applied.