Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp391210imu; Mon, 26 Nov 2018 23:51:06 -0800 (PST) X-Google-Smtp-Source: AJdET5cFbAovwjxTr3Wzd48L6cSRgnwK8SE/jPy0eAuOjC1/ACEkwPTc55iAoFYTQWFH2Mqb7luD X-Received: by 2002:a62:870e:: with SMTP id i14mr32420297pfe.41.1543305066692; Mon, 26 Nov 2018 23:51:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543305066; cv=none; d=google.com; s=arc-20160816; b=ZupFD2yW2pWqWVnw78AmQir1dOlka2aiE8+S6zX9sIN6vyy+OPxrYx0l5XH7igUVxy pieMSWjjDC+kYWgGFAhNLSNPkApNP2kCaGi7mbc6su+1LYsQ8ylreVwD8kPHVQqirTHP qGuk+sSNPTqfYAPzbl0Zo9VANQMWaLhxg8+k2XWrrjcl/7fxqHPFbBIRCseGIvk5I68/ XJqsTvRcyOcjKwdbBCA+OTxbsqHDoQopmkjWWBr9wXqY6z7Z+rvB5mLYYHeTUGrgnUQ/ 0bMC0ibn7Ov79fJX71gPv4SCEuRZwVUY0PsQAVCT7tiz6dn7CBV49J+3KcN4rjtSlzFa dtAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Hzg0BU8kg/sLy2xzoi+GJ3Y21lKjetKV67eUhmiW2OA=; b=tOvFU1drmSal+aRBjAW15WCpQqbti3ygFIal/+iLVXLIMfpUjLVWdYPAmOgiPDxLKd irnpmtOVqHQTjWuUs1RUny7a31A8SEInmJ2e03OQburTigApD1JJdnxz+KQVMC0o3YdV N4Dk1n35jf+E+yLCvHm/1odtpnFzz4X1JryM1GjXCszxJFryoVYaAyN3wDSnTWqPgl0D cedIp4+lLUwa0vLmOvrWR/qgkmhW+mQfp4EcTXesfu9azwvJFbmuZfu9t1/RsH6cwi56 99On2qN0pZKgblSxX90unpJskulA9fLltD22wCM3TTR95PEQniho8VFTVKuMjOi/3cHx f9ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wDrWT2WW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 89si71026pfr.242.2018.11.26.23.50.51; Mon, 26 Nov 2018 23:51:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wDrWT2WW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729275AbeK0Sqi (ORCPT + 99 others); Tue, 27 Nov 2018 13:46:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:32946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728921AbeK0Sqi (ORCPT ); Tue, 27 Nov 2018 13:46:38 -0500 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 456252133F; Tue, 27 Nov 2018 07:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543304977; bh=P0UPadyNC7uElLRqBXxGLEWk4VOx9BdktcmmR1/lSuY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=wDrWT2WWPBsTcog4TinnV2IlPdIkFb/m27vTEbUt9FatjH++WH0dqnlxkmrytLphr DcFLbLe1GYRDyzQx54XZbJ9+DMl8DpJpuyfBjOhx+oeLabtJ3rhhwZbEa8i2nXuPow cuue6ZxaQASlGFH2qIpzAfZDrTKyXXlb6eyP3Azs= Received: by mail-wm1-f44.google.com with SMTP id s11so21138217wmh.1; Mon, 26 Nov 2018 23:49:37 -0800 (PST) X-Gm-Message-State: AA+aEWYcCZPEwgV8K/VE+sHCFmDRJd7t1QftO4wqO4fJ8T/B4/ZFIfXT 5k7+l8vXlMYDifP5Dtltrf+JDohJwUyV23QtYZk= X-Received: by 2002:a1c:b406:: with SMTP id d6mr4692681wmf.129.1543304975695; Mon, 26 Nov 2018 23:49:35 -0800 (PST) MIME-Version: 1.0 References: <1542823573-20228-1-git-send-email-hofrat@osadl.org> <1542823573-20228-2-git-send-email-hofrat@osadl.org> In-Reply-To: <1542823573-20228-2-git-send-email-hofrat@osadl.org> From: Sean Wang Date: Mon, 26 Nov 2018 23:49:26 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack To: hofrat@osadl.org Cc: Linus Walleij , sergio.paracuellos@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nicholas Mc Guire =E6=96=BC 2018=E5=B9=B411=E6=9C=8821= =E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=8810:13=E5=AF=AB=E9=81=93=EF= =BC=9A > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > for the dev_err() messages). The probe function should return an error > if one of the banks failed to initialize properly. > > Signed-off-by: Nicholas Mc Guire > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") > --- > > Patch was compile tested with: omega2p_defconfig, SOC_MT7621=3Dy, > GPIOLIB=3Dy, GPIO_MT7621=3Dy > > Patch is against 4.20-rc3 (localversion-next is next-20181121) > > drivers/gpio/gpio-mt7621.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c > index 1ec95bc..68fca8b 100644 > --- a/drivers/gpio/gpio-mt7621.c > +++ b/drivers/gpio/gpio-mt7621.c > @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) > struct device_node *np =3D dev->of_node; > struct mtk *mtk; > int i; > + int ret; > > mtk =3D devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL); > if (!mtk) > @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, mtk); > mediatek_gpio_irq_chip.name =3D dev_name(dev); > > - for (i =3D 0; i < MTK_BANK_CNT; i++) > - mediatek_gpio_bank_probe(dev, np, i); > + for (i =3D 0; i < MTK_BANK_CNT; i++) { > + ret =3D mediatek_gpio_bank_probe(dev, np, i); > + if (!ret) it should be if (ret < 0) ? > + return ret; > + } > > return 0; > } > -- > 2.1.4 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek