Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1542823573-20228-1-git-send-email-hofrat@osadl.org>
 <1542823573-20228-2-git-send-email-hofrat@osadl.org> <CAGp9LzoT7ueXyyVSYQdWOU0JkQDWMVcwCuSE3gJnEn0fLLjCBA@mail.gmail.com>
 <20181127080113.GA2426@osadl.at>
In-Reply-To: <20181127080113.GA2426@osadl.at>
From:   Sean Wang <sean.wang@kernel.org>
Date:   Tue, 27 Nov 2018 00:32:59 -0800
Message-ID: <CAGp9LzoNKmJvTccQd7Syi_XMew4Mhf_tXsMAAZ+asE5btH9Dag@mail.gmail.com>
Subject: Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure
 up the stack
To:     der.herr@hofr.at
Cc:     bgolaszewski@baylibre.com,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, sergio.paracuellos@gmail.com,
        linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
        hofrat@osadl.org, Matthias Brugger <matthias.bgg@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>
> On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote:
> > Nicholas Mc Guire <hofrat@osadl.org> ??? 2018???11???21??? ?????? ?????=
?10:13?????????
> > >
> > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (exc=
ept
> > > for the dev_err() messages). The probe function should return an erro=
r
> > > if one of the banks failed to initialize properly.
> > >
> > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> > > ---
> > >
> > > Patch was compile tested with: omega2p_defconfig, SOC_MT7621=3Dy,
> > > GPIOLIB=3Dy, GPIO_MT7621=3Dy
> > >
> > > Patch is against 4.20-rc3 (localversion-next is next-20181121)
> > >
> > >  drivers/gpio/gpio-mt7621.c | 8 ++++++--
> > >  1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
> > > index 1ec95bc..68fca8b 100644
> > > --- a/drivers/gpio/gpio-mt7621.c
> > > +++ b/drivers/gpio/gpio-mt7621.c
> > > @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
> > >         struct device_node *np =3D dev->of_node;
> > >         struct mtk *mtk;
> > >         int i;
> > > +       int ret;
> > >
> > >         mtk =3D devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
> > >         if (!mtk)
> > > @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev=
)
> > >         platform_set_drvdata(pdev, mtk);
> > >         mediatek_gpio_irq_chip.name =3D dev_name(dev);
> > >
> > > -       for (i =3D 0; i < MTK_BANK_CNT; i++)
> > > -               mediatek_gpio_bank_probe(dev, np, i);
> > > +       for (i =3D 0; i < MTK_BANK_CNT; i++) {
> > > +               ret =3D mediatek_gpio_bank_probe(dev, np, i);
> > > +               if (!ret)
> >
> > it should be if (ret < 0) ?
>
> I don=C2=B4t think so mediatek_gpio_bank_probe() returns 0 on success
> and all other returns are error paths - while the current code
> only returns negative values I do thik that any non 0 would be
> an error indication so !ret should be fine here.
>
!0 would be true

> thx!
> hofrat
>
> >
> > > +                       return ret;
> > > +       }
> > >
> > >         return 0;
> > >  }
> > > --
> > > 2.1.4
> > >
> > >
> > > _______________________________________________
> > > Linux-mediatek mailing list
> > > Linux-mediatek@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek