Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp434635imu; Tue, 27 Nov 2018 00:40:30 -0800 (PST) X-Google-Smtp-Source: AFSGD/UC/9jbWzUBS2HVC5ZEhnJu0Sfty/fjoHHgQYJMJw69o2FxnANeRAzHBLP+eiRF/uaESdzP X-Received: by 2002:a17:902:70c6:: with SMTP id l6mr26271506plt.30.1543308030455; Tue, 27 Nov 2018 00:40:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543308030; cv=none; d=google.com; s=arc-20160816; b=cDa2hcWDIEsOMYrwJrGoORzzPXTnsbig7ToHUfhGVH57ar2Y4ubJaBmUoFisregjca xO+6UdNK8zpUcgWnkjU1Js11V6BYVTdAgde9+WQWV3xJF7HwbllzdBjGcOn+tf/rjLJv 04rUUL7F1aSCFvRnnKHcHFRE/Kjqb7N38zYP862OhQl7j6MMM8dxOg3RG6w3oW/XAuC9 2zPW8HOsnCcgmXh1h3J0HL2xA5lHoqrB0ysLcJwWnNW13n5nMHJflhIKGpmdaPi7OKlB imOnOsFMFCh76Yw859mBPt+0GEJPgA9iQUBvGp9mQXZjH9aZbuHfNHB2yjh7UmghOAC5 wKXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/gwvU5c2sOWK3f+OiEDyXvRSaaQc1QTpEMfG9dVokFc=; b=jkB7OaBmNRj0pqYg2RZcNBLMbh4NqzmzBwhJ1hx2NjYn7aQ6RBZqhSDoAigPddlB6M Ffwt2xSXRDLF3mHLSt7nXutPekRMvq5gSTVRedHW2Wo6ayvJKHmLSG6Auu64XEYj7bFF mTcKGG4kZhuYYUkKt8DPZOu3ieCJWqxeES+FUklUuXWxnVz1B8XTsCNx3Ph95eZUF47i RJABV018TvHd0m5Xx/Nmo6He57PQ/R+X9CulTLq1Z9bFzflS+E8gXJeUZwcR1rywsZTy GfXJGndv+zJcYsDCqz8E+miwdyVkfc1vsi8mrYNceE6Wv7+acDtS84qDJkxUCMr5D387 yVnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v32si3195823plb.369.2018.11.27.00.40.15; Tue, 27 Nov 2018 00:40:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729539AbeK0TfG (ORCPT + 99 others); Tue, 27 Nov 2018 14:35:06 -0500 Received: from 178.115.242.59.static.drei.at ([178.115.242.59]:33024 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728823AbeK0TfG (ORCPT ); Tue, 27 Nov 2018 14:35:06 -0500 Received: by mail.osadl.at (Postfix, from userid 1001) id 0B7EE5C1002; Tue, 27 Nov 2018 08:37:23 +0000 (UTC) Date: Tue, 27 Nov 2018 09:37:23 +0100 From: Nicholas Mc Guire To: Sean Wang Cc: bgolaszewski@baylibre.com, Linus Walleij , linux-kernel@vger.kernel.org, sergio.paracuellos@gmail.com, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, hofrat@osadl.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Message-ID: <20181127083722.GA7641@osadl.at> References: <1542823573-20228-1-git-send-email-hofrat@osadl.org> <1542823573-20228-2-git-send-email-hofrat@osadl.org> <20181127080113.GA2426@osadl.at> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 27, 2018 at 12:32:59AM -0800, Sean Wang wrote: > > > > On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote: > > > Nicholas Mc Guire ??? 2018???11???21??? ?????? ??????10:13????????? > > > > > > > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > > > > for the dev_err() messages). The probe function should return an error > > > > if one of the banks failed to initialize properly. > > > > > > > > Signed-off-by: Nicholas Mc Guire > > > > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") > > > > --- > > > > > > > > Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y, > > > > GPIOLIB=y, GPIO_MT7621=y > > > > > > > > Patch is against 4.20-rc3 (localversion-next is next-20181121) > > > > > > > > drivers/gpio/gpio-mt7621.c | 8 ++++++-- > > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c > > > > index 1ec95bc..68fca8b 100644 > > > > --- a/drivers/gpio/gpio-mt7621.c > > > > +++ b/drivers/gpio/gpio-mt7621.c > > > > @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) > > > > struct device_node *np = dev->of_node; > > > > struct mtk *mtk; > > > > int i; > > > > + int ret; > > > > > > > > mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL); > > > > if (!mtk) > > > > @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) > > > > platform_set_drvdata(pdev, mtk); > > > > mediatek_gpio_irq_chip.name = dev_name(dev); > > > > > > > > - for (i = 0; i < MTK_BANK_CNT; i++) > > > > - mediatek_gpio_bank_probe(dev, np, i); > > > > + for (i = 0; i < MTK_BANK_CNT; i++) { > > > > + ret = mediatek_gpio_bank_probe(dev, np, i); > > > > + if (!ret) > > > > > > it should be if (ret < 0) ? > > > > I don?t think so mediatek_gpio_bank_probe() returns 0 on success > > and all other returns are error paths - while the current code > > only returns negative values I do thik that any non 0 would be > > an error indication so !ret should be fine here. > > > !0 would be true > ...sorry - stupid me - thanks for catching that ! thx! hofrat