Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp479602imu; Tue, 27 Nov 2018 01:27:59 -0800 (PST) X-Google-Smtp-Source: AJdET5co3aOgzh8Hn1EtBgtoRSnFfSV4dMWcX71cB2Q95mkHV4Xv2Xr7iXeNuis26+pEf2jaE4Cp X-Received: by 2002:a62:2292:: with SMTP id p18mr32864737pfj.9.1543310879577; Tue, 27 Nov 2018 01:27:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543310879; cv=none; d=google.com; s=arc-20160816; b=vahCo/ttl+XVyneekDqs2iRi1TPswckHTxJ1+AqYrso2htuRsgNq8PJLos4aQFqtrQ yLU4g1o8Kc5Qocp+9E0408+Q2XNRMR8vMszUwRBHCmuuTYhErz6xo2/JaxMC0Xfl0pgx BOuuIUaqFuI59MXOuz4j40Rfl2CuxKxvS7VNqy/qULX843B7gRmbQnErPBJ7R5BtPvpL aYjDMoTp08vrlX+GGVOj9ySqJ0x92MV5Sxl/Ryg4CUHN94A/iaXl/x6wirFwn1vzfImk wGm0Y8m+RjkSOPRG78+nTU71aYaP2ZIuC5VVQFFjFBt8n966AzBMsqE+gTWw50RL9SE1 hBEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=COn87GshUX+Skk/zZpyZEhvW/QBv89pIo+S7EcIr2q4=; b=LwikULQYuNpUrHQlzk4lGIh6wdtnLE4TeSyBqL7nFwds7HKIJCAgecbGX2lDbUeICG 5zeTDoTQKaOd95xCtkRJZl1oIzQ2JvaLgZl1+arD2jm3oxUpvwDeJGf4jFlW9/jOdUl4 sbO3bTaEZgMxV/IpaGbo75q2JBHPnXKe+rH8E50cPFCwH1HzMFa9hCkdegI0qqYcpes/ t9bkDaAd+ITbMGuivOeZziztLV6p/Es/e0d0SJ/GeXwdM6b122MHmJtpDJXYGaLtOzq3 b2WKEEnVPrxSwRrovsFyg65HyRHWfg7CMDbQHO4mULP3TUgvCyMZhp87RbUzd2r9ZOeB 3iSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11si3150343plq.287.2018.11.27.01.27.44; Tue, 27 Nov 2018 01:27:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730103AbeK0UYC (ORCPT + 99 others); Tue, 27 Nov 2018 15:24:02 -0500 Received: from mail.bootlin.com ([62.4.15.54]:59830 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728266AbeK0UYC (ORCPT ); Tue, 27 Nov 2018 15:24:02 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 52839207BC; Tue, 27 Nov 2018 10:26:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from localhost (aaubervilliers-681-1-94-205.w90-88.abo.wanadoo.fr [90.88.35.205]) by mail.bootlin.com (Postfix) with ESMTPSA id 233C7207A8; Tue, 27 Nov 2018 10:26:34 +0100 (CET) Date: Tue, 27 Nov 2018 10:26:34 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Maarten Lankhorst , Sean Paul , David Airlie , Chen-Yu Tsai , Thomas Petazzoni , linux-sunxi@googlegroups.com, Daniel Vetter Subject: Re: [PATCH v2 38/43] drm/sun4i: Move access control before setting the register as documented Message-ID: <20181127092634.fq47rifbodtu7tk7@flea> References: <20181123092515.2511-1-paul.kocialkowski@bootlin.com> <20181123092515.2511-39-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7zpweo5ev7pd4bed" Content-Disposition: inline In-Reply-To: <20181123092515.2511-39-paul.kocialkowski@bootlin.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7zpweo5ev7pd4bed Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 23, 2018 at 10:25:10AM +0100, Paul Kocialkowski wrote: > From: Maxime Ripard >=20 > Unlike what is currently being done, the ACCESS_CTRL bit documentation as= ks > that this bit should be set before modifying any register. The code in the > BSP also does this, so make sure we do this as well. >=20 > Signed-off-by: Maxime Ripard This patch (and the subsequent ones) are missing your SoB. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --7zpweo5ev7pd4bed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCW/0NygAKCRDj7w1vZxhR xagcAQCR3nmGAkBaPNZOnJGj7ONr4EPT6xOHFUTrc91GzvQUCQEA5uXd4t/oEC4w OrBnealKA9GlQ0QgDkVL7DyBtO6V7wc= =g0nt -----END PGP SIGNATURE----- --7zpweo5ev7pd4bed--