Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp650607imu; Tue, 27 Nov 2018 04:24:16 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vn4fYufIRWshATIdEyZ4yB1vonTmi/KS//CdbGeecEJzRb/J9u/ZQ18LB7uvXK+ByoH41Q X-Received: by 2002:a63:4d0e:: with SMTP id a14mr29369150pgb.408.1543321456488; Tue, 27 Nov 2018 04:24:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543321456; cv=none; d=google.com; s=arc-20160816; b=c4ZY52xYo4JhVzcNPjjGoKkkZPGScDrWMddqLrjR+XbwYSbgGjxCxYE5AGHTBEo227 Sa0Y52knWPUEpUHdD3IXfF+UicfwiufoqShggvM4zamupnu0DDNlVwvuhEqwg/RSqb+e XLldJAYBKw6vIjHCYByW3tcjtbYtjx76MTkvPFtS5cTnrYEVWXmac3Vl2x2Rc1oPs1Kg sB8lhNHRqYaZhDADLgVcH+SuQ1FIyaskaQQaG3Ba+5hA3tQe/+Le1f31uzlB0O0UYkX6 8GwhOMqNYj9eqtwLO1Nwy/iGAtin5AElGBSDHjhid8a89OecS5lshzbbBElgo+33cnV6 oJMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eXiFuGEYL063RlTNRT8iWSBcS71jHHw57uP7Nz7aM7Y=; b=sF/WIAy9XO7+U1EMFo30wVoYMN37sq/y60BPBZ14Y1qnIbXiN4GnHipTszxaIWzqq5 JOjydJvMzUWoCs5Kb3URJkWYLMt7nvcKo8hOgdV3ufb+joiIN0cPHcnYHLwjRfa85pOT O8qGZxAU73wreT41Oq6zpjxKyHqjR6cKHxufL2ml7OkjCUzcoFj/rULQK95evxzOljO+ RznGibnKRP8Tn0UC/tkLBTxsOtzrNkkS1urbyFQwhllbIIVQQM8L70SYIxjIDiTq59KA HZpRs6jlMWZneaF0qC9JNB1S0PIESkxgT8WBxqDMeFsckNOBOraRhY90hPmXj+sSgT44 alvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hxjXg+BO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32si3828386plg.29.2018.11.27.04.23.58; Tue, 27 Nov 2018 04:24:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hxjXg+BO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731025AbeK0WsX (ORCPT + 99 others); Tue, 27 Nov 2018 17:48:23 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46286 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726494AbeK0WsX (ORCPT ); Tue, 27 Nov 2018 17:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eXiFuGEYL063RlTNRT8iWSBcS71jHHw57uP7Nz7aM7Y=; b=hxjXg+BOawFwbRG2lWLovBhOx cIAa0I1+FdkQABM44HnsXNhnfU9MNj39+hrvGUBqE5rO1i7VitYo5PHZC5rtruqvw94+DjZiFvNQ5 9mQQAPXa4PboR5sEWIEePISubuWrZEwImRuH44Upk4OJt3WP8UW/HTAczC0Plm0Mv5vxg=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gRbsx-0008Ts-Lp; Tue, 27 Nov 2018 11:50:35 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 4D1041125056; Tue, 27 Nov 2018 11:50:35 +0000 (GMT) Date: Tue, 27 Nov 2018 11:50:35 +0000 From: Mark Brown To: Ryan Lee Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Grant Grundler , Kuninori Morimoto , Benson Leung , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset Message-ID: <20181127115035.GB3206@sirena.org.uk> References: <20181126183942.2631-1-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mojUlQ0s9EVzWg2t" Content-Disposition: inline In-Reply-To: <20181126183942.2631-1-ryans.lee@maximintegrated.com> X-Cookie: This end up. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 26, 2018 at 06:46:05PM +0000, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- This really needs a changelog to explain what is going on here, and we need some more documentation in the code. It is *extremely* unusual to have to poll for reset like this, and if the failure mode is I/O errors that's going to be pretty painful. --mojUlQ0s9EVzWg2t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlv9L4oACgkQJNaLcl1U h9A9dAf/YNgemguFt+88Dci5UTRiy8trzQVPKNreg51M7R/0pOnk/fyAC76I3xUj F545w42n+Crp2QiRzn8ONI3Vn4ycdTS9LaUI4jNmubYLQ3cYODGHPREvciFEmpqH cPoCmhPytfuIwf22bUdMgL2BI13WQDSpJJwskYjz66wcu1HRlZyGLUq7Lk2p+nrR gr1Rq+2yCCZiUzTs5eEvEwNP07ePngofy7gMNVeuSWzdiT9fBRPEio0rs8+VXvwr rm+btK3IOGcB6Yc/weV1djHZbxDo6fUhiDS90gSb99sE0J+RX/vhXsjHL+LtYxqJ wWkk7OOlNy9WknhGx6wmXEnhStRK/A== =5YXq -----END PGP SIGNATURE----- --mojUlQ0s9EVzWg2t--