Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp650755imu; Tue, 27 Nov 2018 04:24:25 -0800 (PST) X-Google-Smtp-Source: AJdET5ewVJqujY18cmS0hu3foTs9nWyJDAW7GSrz6cf6JaKfKhoscNmC9M/Rv9/oYiYXBTV35upi X-Received: by 2002:aa7:8354:: with SMTP id z20mr32106102pfm.81.1543321465409; Tue, 27 Nov 2018 04:24:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543321465; cv=none; d=google.com; s=arc-20160816; b=lOlq61pcmhNJfFz2CYp+WmV7Pm/A6FAGG9FiUxLF4V1Gmi1DTG0m5uWZN7g/zjvhSs a1qxBTAPeGf/ub7nCnFtBVg2mw/I6ZkT5XgBDQrfjGujmcgbo/ICqcPtSZz+rx4vsNla GkT0ufFCGMg7zPWEtysCjn1InSfdRbkyfGiNyJf07r0SSLOHwyhiaygclEGLLK06sIBa D/b6oc5SOqbDErXY2p9swtmFudgEi8OK200GC0MkkbxoDDghxCJc6BExweizJBoWZBfb Buz1EXTWknF9b9aHqZrL/gS9TV8egvc2NJOVqNhVJdZ5gO+sbndh9RFF7LCrseSUPFOZ UjPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=vc1Ry0LIVvg6VKjLnPt4ufF/7+RpVsBLUxPZL321nkA=; b=t2DGY/ClJOCZrx/rh5k73iDimOrxkdgx8kZ3yGq4MAJeSkSFXUgfic1aC5c0Qk7Leu 6f0kK+GKAovOA4oKOGtwXEA84+ulu3mYg3eL6NyKeKOJ8Jx8jxqB5gywBnJoxiBrXu0+ NU3OjpsYBobxDwlv3/zKHDSG4rXwrav8+rNq0fRSUpQKdcdCpxFlX9e8QSgoqiBYNvR1 C8El+4UgHHc3ir4cjWCkqXjVxAE1Y7hyC5l90HjX+OEdonDGVpo7zy6R6FOB1ZJAOeyC v9MvzfISThqgnSbesUVga6aPVrdptKDIqFwABy4XkjRS/etFbxRSVSJoT0jbzWPW/B/1 oeYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4si3600811pls.34.2018.11.27.04.24.06; Tue, 27 Nov 2018 04:24:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729922AbeK0Wly (ORCPT + 99 others); Tue, 27 Nov 2018 17:41:54 -0500 Received: from mga02.intel.com ([134.134.136.20]:31800 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729696AbeK0Wly (ORCPT ); Tue, 27 Nov 2018 17:41:54 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2018 03:44:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,286,1539673200"; d="scan'208";a="112262218" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.164]) ([10.237.72.164]) by orsmga002.jf.intel.com with ESMTP; 27 Nov 2018 03:44:14 -0800 Subject: Re: [PATCH v3] xhci: workaround CSS timeout on AMD SNPS 3.0 xHC To: Kai Heng Feng , "Singh, Sandeep" Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "S-k, Shyam-sundar" , "Shah, Nehal-bakulchandra" References: <1542990218-30495-1-git-send-email-Sandeep.Singh@amd.com> <4B40F321-BE33-4D36-BE1A-59139D9AA711@canonical.com> From: Mathias Nyman Message-ID: Date: Tue, 27 Nov 2018 13:48:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4B40F321-BE33-4D36-BE1A-59139D9AA711@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.11.2018 09:44, Kai Heng Feng wrote: > > >> On Nov 24, 2018, at 00:24, Singh, Sandeep wrote: >> >> From: Sandeep Singh >> >> Occasionally AMD SNPS 3.0 xHC does not respond to >> CSS when set, also it does not flag anything on SRE and HCE >> to point the internal xHC errors on USBSTS register. This stalls >> the entire system wide suspend and there is no point in stalling >> just because of xHC CSS is not responding. >> >> To work around this problem, if the xHC does not flag >> anything on SRE and HCE, we can skip the CSS >> timeout and allow the system to continue the suspend. Once the >> system resume happens we can internally reset the controller >> using XHCI_RESET_ON_RESUME quirk >> >> Signed-off-by: Shyam Sundar S K >> Signed-off-by: Sandeep Singh >> cc: Nehal Shah > > Tested-by: Kai-Heng Feng Thanks, applying -Mathias