Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     olivier.moysan@st.com, arnaud.pouliquen@st.com, broonie@kernel.org,
        tiwai@suse.com, mcoquelin.stm32@gmail.com
Cc:     linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
        Wen Yang <wen.yang99@zte.com.cn>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Julia Lawall <julia.lawall@lip6.fr>,
        Wen Yang <yellowriver2010@hotmail.com>,
        linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH] Fix invalid use of sizeof in stm32_sai_add_mclk_provider()
Date:   Tue, 27 Nov 2018 20:35:20 +0800
Message-Id: <20181127123520.44940-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

sizeof(mclk) is 4 or 8 as it is the size of a pointer,
but we want to reserve space for the pointed data.
This issue was detected by using the Coccinelle software.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Olivier Moysan <olivier.moysan@st.com>
CC: Arnaud Pouliquen <arnaud.pouliquen@st.com>
CC: Liam Girdwood <lgirdwood@gmail.com>
CC: Jaroslav Kysela <perex@perex.cz>
CC: Takashi Iwai <tiwai@suse.com>
CC: Maxime Coquelin <mcoquelin.stm32@gmail.com>
CC: Alexandre Torgue <alexandre.torgue@st.com>
CC: Julia Lawall <julia.lawall@lip6.fr>
CC: Wen Yang <yellowriver2010@hotmail.com>
CC: linux-stm32@st-md-mailman.stormreply.com
CC: linux-kernel@vger.kernel.org
---
 sound/soc/stm/stm32=5Fsai=5Fsub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/stm/stm32=5Fsai=5Fsub.c b/sound/soc/stm/stm32=5Fsai=
=5Fsub.c
index ea05cc91aa05..211589b0b2ef 100644
--- a/sound/soc/stm/stm32=5Fsai=5Fsub.c
+++ b/sound/soc/stm/stm32=5Fsai=5Fsub.c
@@ -390,7 +390,7 @@ static int stm32=5Fsai=5Fadd=5Fmclk=5Fprovider(struct s=
tm32=5Fsai=5Fsub=5Fdata *sai)
 	char *mclk=5Fname, *p, *s =3D (char *)pname;
 	int ret, i =3D 0;
=20
-	mclk =3D devm=5Fkzalloc(dev, sizeof(mclk), GFP=5FKERNEL);
+	mclk =3D devm=5Fkzalloc(dev, sizeof(*mclk), GFP=5FKERNEL);
 	if (!mclk)
 		return -ENOMEM;
=20
--=20
2.19.1