Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Nov 2018 09:29:25 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Pavan Kondeti <pkondeti@codeaurora.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched, trace: Fix prev_state output in sched_switch
 tracepoint
Message-ID: <20181127092925.46c77ae7@gandalf.local.home>
In-Reply-To: <CAEU1=PkZQGEZueS=cLOT9kbGeMBptKRL=A56BrBgG85R9PrHDA@mail.gmail.com>
References: <1540882473-1103-1-git-send-email-pkondeti@codeaurora.org>
        <CAEU1=PkZQGEZueS=cLOT9kbGeMBptKRL=A56BrBgG85R9PrHDA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 27 Nov 2018 15:04:25 +0530
Pavan Kondeti <pkondeti@codeaurora.org> wrote:

> Hi Peter/Thomas,
> 
> On Tue, Oct 30, 2018 at 12:25 PM Pavankumar Kondeti
> <pkondeti@codeaurora.org> wrote:
> >
> > commit 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout")
> > tried to fix the problem introduced by a previous commit efb40f588b43
> > ("sched/tracing: Fix trace_sched_switch task-state printing"). However
> > the prev_state output in sched_switch is still broken.
> >
> > task_state_index() uses fls() which considers the LSB as 1. Left
> > shifting 1 by this value gives an incorrect mapping to the task state.
> > Fix this by decrementing the value returned by __get_task_state()
> > before shifting.
> >
> > Fixes: 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout")
> > Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> > ---
> >  include/trace/events/sched.h | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)  
> 
> Can you please review this patch?
> 

I've already tested this patch. I'm working on getting other patches
upstream and this looks like it should be marked for stable. I'll take
it.

Thanks!

-- Steve