Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp117886imu; Tue, 27 Nov 2018 09:48:22 -0800 (PST) X-Google-Smtp-Source: AFSGD/V/cmYqM+zGDvK/86c85Njl3LNAy0gA6T1v39z43nIENOWvmcKSOhWra3QVX/g+46E27NDo X-Received: by 2002:a17:902:1005:: with SMTP id b5mr25403618pla.310.1543340902310; Tue, 27 Nov 2018 09:48:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543340902; cv=none; d=google.com; s=arc-20160816; b=Rcc9MjIln+DuYssnIZIeG27HcRtUUotmkJvbBznSCA5nqZgRtdverRRDhDMQ5PKBr5 Icy6hksvPVIZjf6yJevYETq+Se+j8jT259T5wq3YWB36wRUeNSCgZ5HgDUa6zAkozgoT PqJiM2ar45xWVhcG/O+EAncCw++PEIquyxATo+rpvqxm+Whr+k3J9duU4GmPlRH7Cilm 87XPxVGb+l0Cvx0ZmNQvKJ7WCl4CSlZp81T3j342DVLm7NxWyXj7v4l1mo1Qfkl7uAKl Z5jeGmd2zIS85E1FZS50SD7mCpknwjGkcLu/bOlNikdcQ3RL6Ccn69H72Z04idFO7N0x DETg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LBKZEfWcLztUTidpHxR2IyjLkaWFWaN1tsiISV0ON/k=; b=UePwwLvR1funIjJe07D9vIZiGNUsR3vy/kuTNR0JMX1aqMjEZiaOGDcvvt+rkvGVcs kEmy/rgCjWtat2iXvzU/rK0On6LlmflfO/lTEjauG9Y9GXs/lVe+abEfnuReUf05rx7F vDF4pI44uUdjW5m8tVwn6clDKT+wbXL38+PE3aHN09w0fV7T17spYeE/Rgs9/hLhnfO2 5QA2gsMwy2fDTb8EJx2Y8EOsdUNPC6NnROoWVuPIfcrMhgEx8C/EcPLDE82R53sBzRF+ gUHH1HmlHS/oE/fvz+84nbLAuKAndyM2HPvSUXfyvECVJ8b/Qv00uAyeHJLoSp2+Hlo+ 75iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4si4180333pgk.350.2018.11.27.09.47.47; Tue, 27 Nov 2018 09:48:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731903AbeK1El5 (ORCPT + 99 others); Tue, 27 Nov 2018 23:41:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726288AbeK1El5 (ORCPT ); Tue, 27 Nov 2018 23:41:57 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 02EF7811D3; Tue, 27 Nov 2018 17:43:18 +0000 (UTC) Received: from parsley.fieldses.org (ovpn-124-225.rdu2.redhat.com [10.10.124.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 900E219747; Tue, 27 Nov 2018 17:43:17 +0000 (UTC) Received: by parsley.fieldses.org (Postfix, from userid 2815) id 77FB1180365; Tue, 27 Nov 2018 12:43:16 -0500 (EST) Date: Tue, 27 Nov 2018 12:43:16 -0500 From: "J. Bruce Fields" To: kernel test robot Cc: NeilBrown , Jeff Layton , LKML , Jeff Layton , lkp@01.org, linux-nfs@vger.kernel.org Subject: Re: [LKP] [fs/locks] 83b381078b: will-it-scale.per_thread_ops -62.5% regression Message-ID: <20181127174315.GA29963@parsley.fieldses.org> References: <20181127060102.GF6163@shao2-debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181127060102.GF6163@shao2-debian> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 27 Nov 2018 17:43:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the report! On Tue, Nov 27, 2018 at 02:01:02PM +0800, kernel test robot wrote: > FYI, we noticed a -62.5% regression of will-it-scale.per_thread_ops due to commit: > > > commit: 83b381078b5ecab098ebf6bc9548bb32af1dbf31 ("fs/locks: always delete_block after waiting.") > https://git.kernel.org/cgit/linux/kernel/git/jlayton/linux.git locks-next > > in testcase: will-it-scale > on test machine: 88 threads Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz with 64G memory > with following parameters: > > nr_task: 16 > mode: thread > test: lock1 So I guess it's doing this, uncontended file lock/unlock?: https://github.com/antonblanchard/will-it-scale/blob/master/tests/lock1.c Each thread is repeatedly locking and unlocking a file that is only used by that thread. By the way, what's the X-axis on these graphs? (Or the y-axis, for that matter?) --b. > will-it-scale.per_thread_ops > > 450000 +-+----------------------------------------------------------------+ > | | > 400000 +-+ +..+.. .+..+.. .+..+..+...+..+..+.. +.. .+.. ..| > 350000 +-+ .. +. +. .. +. +..+ | > | + + + : | > 300000 +-+ : : | > 250000 +-+ : : | > | : : | > 200000 +-+ : : | > 150000 +-+ : : | > O O O O O O O O O O O O O O O O O :O: O O O O O > 100000 +-+ : : | > 50000 +-+ : : | > | : | > 0 +-+----------------------------------------------------------------+ > > > will-it-scale.workload > > 7e+06 +-+-----------------------------------------------------------------+ > | +...+.. .+..+..+ + +.. | > 6e+06 +-+ +..+.. .. .+..+..+. + + + .. ..| > | .. + +. + + + + +..+ | > 5e+06 +-++ + + : | > | : : | > 4e+06 +-+ : : | > | : : | > 3e+06 +-+ : : | > | O O : : O O | > 2e+06 O-+O O O O O O O O O O O O O O : O: O O O > | : : | > 1e+06 +-+ : : | > | : | > 0 +-+-----------------------------------------------------------------+ > > > will-it-scale.time.user_time > > 250 +-+-------------------------------------------------------------------+ > | .+.. .+.. +.. | > |.. +...+.. .+. .+...+..+..+. +.. +.. .. . ..| > 200 +-+ .. +. +. . .. + +..+ | > | + + + : | > | : : | > 150 +-+ : : | > | : : | > 100 +-+ : : | > | O O : : | > O O O O O O O O O O O O O O O :O: O O O O O > 50 +-+ : : | > | : : | > | : | > 0 +-+-------------------------------------------------------------------+ > > > will-it-scale.time.system_time > > 5000 +-+------------------------------------------------------------------+ > 4500 O-+O..O..O...O..O..O..O..O..O..O...O..O..O..O..O..O O O...O..O..O..O > | : : | > 4000 +-+ : : | > 3500 +-+ : : | > | : : | > 3000 +-+ : : | > 2500 +-+ : : | > 2000 +-+ : : | > | : : | > 1500 +-+ : : | > 1000 +-+ : : | > | : | > 500 +-+ : | > 0 +-+------------------------------------------------------------------+ > > > [*] bisect-good sample > [O] bisect-bad sample