Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Nov 2018 13:18:59 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Will Deacon <will.deacon@arm.com>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] arm64: ftrace: Fix to enable syscall events on arm64
Message-ID: <20181127131859.79ce7da9@gandalf.local.home>
In-Reply-To: <20181127165848.GA19569@arm.com>
References: <CAA93ih1-xpm1P0suT6SNCc_ARvAfyBEwb0-uKFikM5k4CvG8jg@mail.gmail.com>
        <154333618522.27355.8094935453351562295.stgit@devbox>
        <20181127165848.GA19569@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 27 Nov 2018 16:58:49 +0000
Will Deacon <will.deacon@arm.com> wrote:

> This looks fine to me, but I'm curious about whether this is supposed to
> work with compat syscalls as well, where the prefix is "__arm64_compat_".
> 
> If we broadly follow the x86 lead, we'd have:
> 
> 	return (!strncmp(sym, "__arm64_", 8) && !strcmp(sym + 8, name)) ||
> 		(!strncmp(sym, "__arm64_compat_", 15) && !strcmp(sym + 15, name));
> 
> Do we need to handle compat (i.e. 32-bit) tasks here?

Only if you want to trace compat syscalls as well ;-)

-- Steve