Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp424567imu; Tue, 27 Nov 2018 14:44:10 -0800 (PST) X-Google-Smtp-Source: AJdET5etjSEEuyfZha08ecHyrr21G1Pl6Zz7F62o6iimt9aP1r+8gBXJW6H0fTO4DMzP5mlYKZqk X-Received: by 2002:a62:db41:: with SMTP id f62mr35542141pfg.123.1543358650026; Tue, 27 Nov 2018 14:44:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543358649; cv=none; d=google.com; s=arc-20160816; b=aliQWtQJXbCqZpV5ce2QmKKZuTJ1j53JZHf9GAPexQ43MDOGT+zieUX52HNw0Gok7w FPjWIBQJ2Wu0UmDg5icA10Fu8JqRHgAKB3LFOBGWhEk/5FmaSeeR2BAQHUOhVRZHyKeq UNHIZ0yi5Gipv70L93AX5SGOOXgb6qamU9B+equP6pGQPCEe3JcBQsqzNO6gSy8ll+LC N2nlwHPKVNuWzSaaNbJEkKgD+AvjcozTrsgAXrJXq0wsfzJjUPsCbGt2qXUgJlk0qQXt FfLSBQ856YWp7OB+JyZ9kxDtBmQp8SDYzEzkwRkMLjFkgj4RKTknqsw45K2xFEqIxs1U uy9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=dAGwOYtHt713s1eoZTjI5evLtpSDGsbzqYCDOo2xDoY=; b=oqOv88+EvZl59+eE78qoBSMLRhDKtdSx927XQY7hmvZjzWy82tVIqB5gCcj5JqRlt0 QukOee4FQETDjn+/eEok1+m5PuYTL/DMRwt45vjg7D/Ql3wg1gvNUehrf3WQg4Lbe1iW fcnX3QBICBjopcRlJ9b8sP7/rOzqrvRROnay7oratEp/XJ+gVfxcYby2X7N3i3qOCOBr nTi2K5AfAVJE/6e34MLKkRqpWFjdiGTktpLPcIJwUr3JTRaW+eD9acMsBHQPnAd7L62u /1hFI/oHH5CWq6Tv1PvjB3HK5drolNtP0cjnSIdqz2WK78AFSOiomwWxhtkEyPa6Lz0v ZQzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=GGOPettL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a190si5084181pgc.423.2018.11.27.14.43.54; Tue, 27 Nov 2018 14:44:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=GGOPettL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbeK1Jm1 (ORCPT + 99 others); Wed, 28 Nov 2018 04:42:27 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:54954 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbeK1Jm1 (ORCPT ); Wed, 28 Nov 2018 04:42:27 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wARMd0NA178123; Tue, 27 Nov 2018 22:42:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=dAGwOYtHt713s1eoZTjI5evLtpSDGsbzqYCDOo2xDoY=; b=GGOPettLi3mwqG97d5enpCDWs8BLqsFg4cqgjEcQhsz4pSFgFncna1iRdyJuTMprd2+I +pImn4Nzqmj+R9BibA+7cDr8PhNiVIHHH+FWmcE/V/wDgEzL7pUppOB8TFutFbyQgET0 BL2qU8JfNWTpfcx8lXHkbG/hISkCD3uQ82zrGqBcopd0MVuO4lZDPk0XiIEay3L6A6Tn E9z29nXrzV31SCBboKD301OMooW3nGpQjzAnCd/b2e2O75AMwtvA0jToBF9FJE5JUyre 5X2W5m1YIAiKObeuaV5y7GUry8XSxFwRJc4Af4pV8ipriyP6ILnCvHr6GRXQlIvWcdVN KA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2nxy9r6xpu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Nov 2018 22:42:56 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wARMgtU4030838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Nov 2018 22:42:55 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wARMgtAW017264; Tue, 27 Nov 2018 22:42:55 GMT Received: from dhcp-burlington7-2nd-B-east-10-152-55-162.usdhcp.oraclecorp.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 27 Nov 2018 14:42:54 -0800 Subject: Re: [PATCH] Revert "xen/balloon: Mark unallocated host memory as UNUSABLE" To: Igor Druzhinin , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: jgross@suse.com, jbeulich@suse.com References: <1543352301-29952-1-git-send-email-igor.druzhinin@citrix.com> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <1fe8626c-6832-5ffd-9331-48925324cc4e@oracle.com> Date: Tue, 27 Nov 2018 17:42:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <1543352301-29952-1-git-send-email-igor.druzhinin@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9090 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811270189 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/27/18 3:58 PM, Igor Druzhinin wrote: > This reverts commit b3cf8528bb21febb650a7ecbf080d0647be40b9f. > > That commit unintentionally broke Xen balloon memory hotplug with > "hotplug_unpopulated" set to 1. As long as "System RAM" resource > got assigned under a new "Unusable memory" resource in IO/Mem tree > any attempt to online this memory would fail due to general kernel > restrictions on having "System RAM" resources as 1st level only. > > The original issue that commit has tried to workaround fa564ad96366 > ("x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 00-1f, 30-3f, > 60-7f)") also got amended by the following 03a551734 ("x86/PCI: Move > and shrink AMD 64-bit window to avoid conflict") which made the > original fix to Xen ballooning unnecessary. > > Signed-off-by: Igor Druzhinin > --- > In mail thread [1] it was agreed to revert the change due to technical > comlications of fixing it and the fact that there is no any strong reason > to keep it. > > [1] https://lists.xenproject.org/archives/html/xen-devel/2018-11/msg02834.html > --- > arch/x86/xen/enlighten.c | 78 ------------------------------------------------ > arch/x86/xen/setup.c | 6 ++-- > drivers/xen/balloon.c | 65 ++++++---------------------------------- > include/xen/balloon.h | 5 ---- > 4 files changed, 13 insertions(+), 141 deletions(-) Reviewed-by: Boris Ostrovsky