Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Nov 2018 12:49:00 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] selftests: add TPM 2.0 tests
Message-ID: <20181127224900.fpbqujcsqwgxpwyq@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>
References: <20181127221059.25966-1-jarkko.sakkinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cixxykv7p6jttu3e"
Content-Disposition: inline
In-Reply-To: <20181127221059.25966-1-jarkko.sakkinen@linux.intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--cixxykv7p6jttu3e
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 27, 2018 at 02:10:48PM -0800, Jarkko Sakkinen wrote:
> Added the tests that I've been using for testing TPM 2.0 functionality
> for long time but have out-of-tree so far residing in
>=20
> https://github.com/jsakkine-intel/tpm2-scripts
>=20
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Just one thing I didn't really understand:

> +    def start_auth_session(self, session_type, name_alg =3D TPM2_ALG_SHA=
1):
> +        fmt =3D '>HII IIH16sHBHH'
> +        cmd =3D struct.pack(fmt,
> +                          TPM2_ST_NO_SESSIONS,
> +                          struct.calcsize(fmt),
> +                          TPM2_CC_START_AUTH_SESSION,
> +                          TPM2_RH_NULL,
> +                          TPM2_RH_NULL,
> +                          16,
> +                          '\0' * 16,
> +                          0,
> +                          session_type,
> +                          TPM2_ALG_NULL,
> +                          name_alg)
> +
> +        return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
> +
> +    def __calc_pcr_digest(self, pcrs, bank_alg =3D TPM2_ALG_SHA1,
> +                          digest_alg =3D TPM2_ALG_SHA1):
> +        x =3D []

Is there a reason for using `'\0' * 16` there instead of just 0?

--=20
Cheers,
Joey Pabalinas

--cixxykv7p6jttu3e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv9ydsACgkQ2rGdfm9D
tVJG2g/8DPPQ8Mt17gIFkwZ5htEJKnOHRgQF7iopCqkYwEbY/EDFflNsnmrSe5aS
nl9ZBIqr/3NG5JKpnqOEIaPBLC6omChvwIfjOMjHyc3EUwOPEu3vWeofvvOVIxQK
iJqiFKzHs9f2jZrpNZDeBlzPJnPyEqrWVz8rRZB242Xl0cLudmhGxrALCdSBXBW/
QB0XDHb38X04h7/zpjEWqfELgrZEDCVhqvfkylM/CB/H1MHo/d1fI2vxK2N/bF1o
fphW+eNB4/uZKZXHAvedp5mndNSbazY3aOnooxUpHnD7FsvHO9Oh1GB6TYjZhcQr
wd4lnxbigNZQ7C+ps5d1vWRm5Y1K65wWjBkt1u96qFsXKZ57eFWFZ2MF3yahvl5V
TliSHhGrqNVEH4PT5RpTqqdV6OLi5lJHfueIkpKZ++3HcJlm4b0fQfDlfYkHRw5Z
0V53m2fRsPxsdglz5hLSr1qFtCkiZXVodHuP4YNjjKJgMdutGSW1zgo1imLGQLEF
3h4xYqgMFADpmzeX1aoQqUC47st+aWE2r4j30jnlqB9+wGv+LdsYzJfRmJccyWIz
6EYpqhUAJUdOzsqoweY9+NJknhToCStalj7nZhAzlrbtNCaUnWk5Yt3S2fs3VHJx
rW5ZRrS7ZtJ1MXy2f3BQQRBUeBWjghgqw4f8eLw2SPEGeF5zEug=
=Is49
-----END PGP SIGNATURE-----

--cixxykv7p6jttu3e--