Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Nov 2018 12:53:07 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Joey Pabalinas <joeypabalinas@gmail.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests: add TPM 2.0 tests
Message-ID: <20181127225307.3wc3gd7zmfauie6i@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>
References: <20181127221059.25966-1-jarkko.sakkinen@linux.intel.com>
 <20181127224900.fpbqujcsqwgxpwyq@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kdifjrdhqbntdhag"
Content-Disposition: inline
In-Reply-To: <20181127224900.fpbqujcsqwgxpwyq@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--kdifjrdhqbntdhag
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote:
> > +    def start_auth_session(self, session_type, name_alg =3D TPM2_ALG_S=
HA1):
> > +        fmt =3D '>HII IIH16sHBHH'
> > +        cmd =3D struct.pack(fmt,
> > +                          TPM2_ST_NO_SESSIONS,
> > +                          struct.calcsize(fmt),
> > +                          TPM2_CC_START_AUTH_SESSION,
> > +                          TPM2_RH_NULL,
> > +                          TPM2_RH_NULL,
> > +                          16,
> > +                          '\0' * 16,
> > +                          0,
> > +                          session_type,
> > +                          TPM2_ALG_NULL,
> > +                          name_alg)
> > +
> > +        return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
> > +
> > +    def __calc_pcr_digest(self, pcrs, bank_alg =3D TPM2_ALG_SHA1,
> > +                          digest_alg =3D TPM2_ALG_SHA1):
> > +        x =3D []
>=20
> Is there a reason for using `'\0' * 16` there instead of just 0?

Nevermind, I keep forgetting that the * operator on strings performs
repetition. I've been programming too much C lately, it seems.

Acked-By: Joey Pabalinas <joeypabalinas@gmail.com>

--=20
Cheers,
Joey Pabalinas

--kdifjrdhqbntdhag
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv9ytIACgkQ2rGdfm9D
tVI8YBAAj8anlvZDjgpEaTmqa5oicbayoo+Zl5VmO6NgWvuPOs4DBx7PDeBlCUl2
qF7CYw8aWlSgW1XqsZQIrP33cnzp7rD4tmGuEvtx985e3o/zuru4e0QEtBadPA+G
6Bijx7Ba/9ddE4lRa8bSuN0ePEYWMKI+RQ9bPJEuBlMqUbugsYOP4BdZQMYhLOHB
mFqmCgOjIOiW69ydAEou3rLaco4hjUh2O/UmCeY6q8peEzPz5Hmb+oy1y/Q2jcMA
PQcFX7Ngwmxy2zLEI6oCd50kI1RhP7XeYOF9SYfvOAeK08aKsbk1r7/zeVM2K9bt
dZhSx6fxl0mwwr755V8qjeiArDkmv5ugtqySlWo0v23kbK1lBFsWIri9nOygCVXU
Ns4fYBa/d4AYTJGKsV3FA8WLWHNc039iMm5AjPPjbUHNzgUw30RwgGXwyLh/zZdo
KtmhtSr9a26w7IHvffxxfZJRjJuoZH27n9/7KJAxS4GYI1YePxZmg1mOmY809m+e
xr3XiESPRh/1SwjWPYdYvrAAJeVHlDEtnceDRpqr4JBBDB7q/ZdkrIkCYqElw2Iq
zbFhiN3G6+FUB35WWzT+TBD4AzVSZDzwXqoPSn9+POWmtJZqO+CjkMmNOjO88LgE
29HJPFu3nbg3z/RTN2AVVDq4fceMHFnv/91Pc7ODHRLWh/lrMF8=
=CD+q
-----END PGP SIGNATURE-----

--kdifjrdhqbntdhag--