Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: minyard@acm.org
Subject: Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle
 devm_kasprintf() failure case
To:     "Wang, Haiyue" <haiyue.wang@linux.intel.com>,
        Nicholas Mc Guire <hofrat@osadl.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
References: <1542812905-27337-1-git-send-email-hofrat@osadl.org>
 <9320680f-679e-fc89-4349-17dbbd30bbfc@acm.org>
 <67962bdd-f7db-5a7d-e5d8-baaefd748ab5@linux.intel.com>
From:   Corey Minyard <minyard@acm.org>
Message-ID: <9f64f5dd-6689-e28d-3316-bf7feb83ba46@acm.org>
Date:   Tue, 27 Nov 2018 18:55:25 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <67962bdd-f7db-5a7d-e5d8-baaefd748ab5@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/27/18 6:54 PM, Wang, Haiyue wrote:
> [Resend for wrong reply HTML format mail]
>
> Great check for making kcs_bmc module be more stable and handle things 
> gracefully.
>
> My tag if needed.
>      Reviewed-by: Haiyue Wang<haiyue.wang@linux.intel.com>
>
Thanks for the review, it's included.

-corey


> 在 2018-11-27 21:36, Corey Minyard 写道:
>> On 11/21/18 9:08 AM, Nicholas Mc Guire wrote:
>>> devm_kasprintf() may return NULL if internal allocation failed so this
>>> assignment is not safe. Moved the error exit path and added the !NULL
>>> which then allows the devres manager to take care of cleanup.
>>
>>
>> Added the original author.  This looks correct to me, I've included 
>> it, but I would
>> like Haiyue to comment, if possible.
>>
>> Thanks,
>>
>> -corey
>>
>>
>>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>>> Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device name") 
>
>
> _______________________________________________
> Openipmi-developer mailing list
> Openipmi-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openipmi-developer