Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp713487imu; Tue, 27 Nov 2018 20:52:58 -0800 (PST) X-Google-Smtp-Source: AFSGD/UKKNT2X6TQPCgUXb59C30MBgjUZ/pmd3mUSxirXyqYPEjOSjKJiUEH6ceu7TqvUqa9QXlv X-Received: by 2002:a17:902:ab92:: with SMTP id f18mr12118763plr.221.1543380778527; Tue, 27 Nov 2018 20:52:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543380778; cv=none; d=google.com; s=arc-20160816; b=NYyAbg6oC3mBfJ7sfY29A/ZXU65uXwDXn0/toKMU1RPOKruzcBZXIojl5Ksm2mZtTS KeP9i03ps9dVglCnC8IYwMP/LXes7sDvuYUGdxBtQTPa3aAwV576GKfodoE4Z+HoExow vySzTiwTd6AtquPhv/LhraNaJs7mGau1CsjGpU34rDl3RqcG81vxariaQwLBVhmaha4Q K5QCPJ/zTrAAVhn0EQFkezLYzWLWDhjfTajOBK16WaoOtESyZI5v4vKHsqClCBruMEex TcnjPcEYmrYP8px1qNgo6rvELm3+6DCnZlCwBw16mzY9Xq9Y1g9Ayb5EVS7ndd2eXh7O sRfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kgbCF5wrFpWyYt0IkZ0DvIZuGYRrFjE1GGxFjGjx2uo=; b=STXfemFBKpNSk5S4jXKOhKXDXbYbjeFQX2XW3aG3GJDPz1PWK53aHTpe/HT6RGRi0e 6PV9u3fUCJH3mDXlIaw5xUxNwSWKZAJlr4gGouKVS/0wMM+u8ZQbH8q6BpvzZMVQYZ12 eWB0wgoFiCQZ2WeOtlgngdJdi0aNix4XLzNseJZ478Jsewh/BgDc9gWZU+n0MivWpyAk AOAFxgCgtQUVSCZx6YOTrpJi7A9bo85lRrl6U5OAh6MDz9iyfWRPWGXz1t9VCFseV55p Od8of0mJDmtkzZogQvUnUHs79kGRhiRnAnwQwpeCMd4F6pMcS1hU5b2BrLKS9oburaby VHSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si6559221plh.245.2018.11.27.20.52.44; Tue, 27 Nov 2018 20:52:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbeK1Pve (ORCPT + 99 others); Wed, 28 Nov 2018 10:51:34 -0500 Received: from gateway30.websitewelcome.com ([192.185.168.15]:18743 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727396AbeK1Pvc (ORCPT ); Wed, 28 Nov 2018 10:51:32 -0500 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A4C075A5D for ; Tue, 27 Nov 2018 22:27:18 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id RrRWgMvgFBcCXRrRWgSBTD; Tue, 27 Nov 2018 22:27:18 -0600 X-Authority-Reason: nr=8 Received: from [189.250.78.127] (port=58264 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gRrRV-001kRt-Sj; Tue, 27 Nov 2018 22:27:18 -0600 Date: Tue, 27 Nov 2018 22:27:15 -0600 From: "Gustavo A. R. Silva" To: Anil Gurumurthy , Sudarsana Kalluru Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 10/41] scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs Message-ID: <5cc329185c0b92f3aad001fc1afa54996a2c1112.1543374820.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.78.127 X-Source-L: No X-Exim-ID: 1gRrRV-001kRt-Sj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.78.127]:58264 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 99 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "!!! fall through !!!" with a "fall through" annotation, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/bfa/bfa_fcs_lport.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c index b4f2c1d8742e..646f09f66443 100644 --- a/drivers/scsi/bfa/bfa_fcs_lport.c +++ b/drivers/scsi/bfa/bfa_fcs_lport.c @@ -6430,9 +6430,7 @@ bfa_fcs_vport_sm_logo_for_stop(struct bfa_fcs_vport_s *vport, switch (event) { case BFA_FCS_VPORT_SM_OFFLINE: bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE); - /* - * !!! fall through !!! - */ + /* fall through */ case BFA_FCS_VPORT_SM_RSP_OK: case BFA_FCS_VPORT_SM_RSP_ERROR: @@ -6458,9 +6456,7 @@ bfa_fcs_vport_sm_logo(struct bfa_fcs_vport_s *vport, switch (event) { case BFA_FCS_VPORT_SM_OFFLINE: bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE); - /* - * !!! fall through !!! - */ + /* fall through */ case BFA_FCS_VPORT_SM_RSP_OK: case BFA_FCS_VPORT_SM_RSP_ERROR: -- 2.17.1