Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp715763imu; Tue, 27 Nov 2018 20:56:50 -0800 (PST) X-Google-Smtp-Source: AFSGD/VJR6BD2FDS+kDOSZUcnVPWYwzHYvwEky22OlTEDSG5NubZtwGpvKJIoR82geT/Mjqt28BO X-Received: by 2002:a63:bf0b:: with SMTP id v11mr32482814pgf.302.1543381010022; Tue, 27 Nov 2018 20:56:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543381009; cv=none; d=google.com; s=arc-20160816; b=eQ9x1jwJJbKjtJRJ4Ipb1BEs7JZZqd5NEYmnBNsYoBOgyNTZuYtjNksPV5jfCn4rxo 9bk3hmVOWIEPoDyOxiP1uRKITwLuVgeuBTOdfS2L7zBHVBl6vsH6otxs6lu3PLIY/HGT Hk+DquvN3pJn690mWdY6nNZW2bqTJegKnrkPp2tbAd+i5uNbY6pQRYiS/F+hMeM1GoaZ XFk/KZPRIjeO1Q8V+Xo3fZIeLIbtYOAYHq3KcyQXGELnl3LLTf71n4ExI3+Qh9uPg5kz 5hLGfG8v0+8SyIRfbTavp6WlVa0oC3y6W9RC5qdqeYI7oDRNnRms1UP5HiWkD4wzV0wq MyJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wa71hwf9hq3GFIXrHh9M+XzXW4teWH/UZqpYw1oEh60=; b=m7KsiJADbkV7eqA7w104qZcJKaLK9ytdOEelG246d1ynwHmb0mXq8RmS5Yp5iIp1Rb GgmMy5AHbQxaDsFpmrDfPtXDBFpH03YZ6x3uVyU7gf+2ZpbeCsrUVlMzRp9OR/IOkvAm HFTt31sIo94CQGJwhLan8EXDrTIE+lAx8p/J3cC8klKuTd7t+a9p8dn13UgVIhhgRlmV SKVa+kgGOVpDqvW2nEsfS3rMoyLWRn9X+wzyk/jfr0eVfDKfO63peIjn8Lj2Ob0+Ieu1 HwI57SuruM82rMO5g7uZykjNYFjpnEOVBzWnSTzt7f2Bs0VKmTauOq6cnY3YJN/kH4yX X5Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k35si5318650pgm.225.2018.11.27.20.56.34; Tue, 27 Nov 2018 20:56:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727497AbeK1P4S (ORCPT + 99 others); Wed, 28 Nov 2018 10:56:18 -0500 Received: from gateway32.websitewelcome.com ([192.185.145.111]:26457 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727312AbeK1P4S (ORCPT ); Wed, 28 Nov 2018 10:56:18 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 79B6D2AC469 for ; Tue, 27 Nov 2018 22:31:27 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id RrVXgzPOlaSeyRrVXgC2MW; Tue, 27 Nov 2018 22:31:27 -0600 X-Authority-Reason: nr=8 Received: from [189.250.78.127] (port=58342 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gRrVV-001nzb-VR; Tue, 27 Nov 2018 22:31:26 -0600 Date: Tue, 27 Nov 2018 22:31:23 -0600 From: "Gustavo A. R. Silva" To: James Smart , Dick Kennedy Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 24/41] scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs Message-ID: <8db99b2700dd1589b8cf5ddb6b3de84dfe1e9f82.1543374820.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.78.127 X-Source-L: No X-Exim-ID: 1gRrVV-001nzb-VR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.78.127]:58342 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 177 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "Drop thru" with a "fall through" annotation, which is what GCC is expecting to find. Addresses-Coverity-ID: 114976 ("Missing break in switch") Addresses-Coverity-ID: 114977 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 6c2fb55d739b..1a61806739ff 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -4645,9 +4645,11 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba, case CMD_GEN_REQUEST64_CR: if (iocb->context_un.ndlp == ndlp) return 1; + /* fall through */ case CMD_ELS_REQUEST64_CR: if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID) return 1; + /* fall through */ case CMD_XMIT_ELS_RSP64_CX: if (iocb->context1 == (uint8_t *) ndlp) return 1; @@ -5791,7 +5793,7 @@ lpfc_disc_timeout_handler(struct lpfc_vport *vport) case LPFC_LINK_UP: lpfc_issue_clear_la(phba, vport); - /* Drop thru */ + /* fall through */ case LPFC_LINK_UNKNOWN: case LPFC_WARM_START: case LPFC_INIT_START: -- 2.17.1