Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp717280imu; Tue, 27 Nov 2018 20:59:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/XMKtOz8nb/ywp9beWfMGCktAGj5lqlRqbrZVV4C7uKycoL4plGdzNHAx05mJAh1zNXTG9d X-Received: by 2002:a63:1f1c:: with SMTP id f28mr31954808pgf.193.1543381159681; Tue, 27 Nov 2018 20:59:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543381159; cv=none; d=google.com; s=arc-20160816; b=sfn6gLEz30dq+DvgPYFCTlFIYloILGh0m0VcLCsLHIha+NUzvlujNMkx5e7d38ZZlv TBSLvXjdFXqTCTUg2zP3Sa3YXXis1ICRBVVA/G06aDxkrxEtcG/AzUfigkiED876ncQm nCW0O8Ukc8xfmcuisXh8JOOrm/0UrsVqsZ1HgSZLgkQ1Y9S5fGgXcuuFZ1vjnvm/HqvH o5t5qDy2k7txNWtti6PvFjPQFnABQWcAyFqtfphZL5qmd/RN4sIVuGmmmgOKhO/nt2l+ SYV21wENDEM87Qmf3FC3stkcvLKXqwqClW0/b+CHcweGq3rBB11Z9kNeSObxqKvaF6FS wxsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=O8y/H2dnxEBLuon6OGF8hIjJM/BjPFruZoJZVSTmK68=; b=UalKhRPkM1IqOQD1BpnIBk7bESy1UhE0Qa8pmx7zqEMI2GqObFnB2w0QJMLgybleJ5 dpAKqGg1PcVIpgx0b6v23Crkssd8LC2umtbIumJ4m6M8pKnNIbpoI0yq2/+2V4OzlZYD Cbo+aQLFVy1IPhSCc85QOlE19x3K3FSMU1mRzxpcuN7zRFcyz+j8UuaqR9KZq7YhraF1 wrLuFgXpmBwqQLdgBjNTqBJRYLvjh/jlbhxiXSjdQEbQX81daklnxw8HIvCs5RInbiwu eciaB745i9W9LbmH7ivfZyyjPkRmbfGaJAeQf7bKQyODobQ+QCS3LJSnIdx6nLsb0whZ /L8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 144si5773905pga.322.2018.11.27.20.59.04; Tue, 27 Nov 2018 20:59:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727547AbeK1P5H (ORCPT + 99 others); Wed, 28 Nov 2018 10:57:07 -0500 Received: from gateway22.websitewelcome.com ([192.185.47.168]:28586 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbeK1P5G (ORCPT ); Wed, 28 Nov 2018 10:57:06 -0500 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id B10EF62F9 for ; Tue, 27 Nov 2018 22:32:37 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id RrWfgJLUA957pRrWfg2fS3; Tue, 27 Nov 2018 22:32:37 -0600 X-Authority-Reason: nr=8 Received: from [189.250.78.127] (port=58360 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gRrWe-001pBh-Cr; Tue, 27 Nov 2018 22:32:37 -0600 Date: Tue, 27 Nov 2018 22:32:34 -0600 From: "Gustavo A. R. Silva" To: Kashyap Desai , Sumit Saxena , Shivasharan S , megaraidlinux.pdl@broadcom.com Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 30/41] scsi: megaraid_sas_fusion: Mark expected switch fall-through Message-ID: <5fceeac101cc3dfe4a129764a139c1b616cba292.1543374820.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.78.127 X-Source-L: No X-Exim-ID: 1gRrWe-001pBh-Cr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.78.127]:58360 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 217 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "Fall thru" with a "Fall through" annotation and added a dash as a token in order to separate the "Fall through" annotation from the rest of the comment on the same line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index c5e6bccb0895..8f37ad83be9a 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -3453,7 +3453,7 @@ complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex) atomic_dec(&lbinfo->scsi_pending_cmds[cmd_fusion->pd_r1_lb]); cmd_fusion->scmd->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG; } - //Fall thru and complete IO + /* Fall through - and complete IO */ case MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST: /* LD-IO Path */ atomic_dec(&instance->fw_outstanding); if (cmd_fusion->r1_alt_dev_handle == MR_DEVHANDLE_INVALID) { -- 2.17.1