Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp726858imu; Tue, 27 Nov 2018 21:12:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wx4q4ozmpfDgETxf9gMZrZmacxuhl1i9RCCx94u7qBsrYCPdSGqXcaMgb4sS+QP7qq0uUg X-Received: by 2002:a62:9fd9:: with SMTP id v86mr13853060pfk.191.1543381931829; Tue, 27 Nov 2018 21:12:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543381931; cv=none; d=google.com; s=arc-20160816; b=DM5T2ago9BzizwNFUPpzObdKADpurmrIW8AfjC6RkqDUiwDaQQjapGigSnLCAvn0k+ iigdQbFbiu+5aWKhtYVCcYYnNfKt/ODA+zj5LTXFmXc7E7Q/n8CtiCg+M+Qt1bW9L2C2 dgBuGA5PEw0pOhhC8nsA4qO8F9aYJz2YlyppJoXW5AwTWl+zdbfrNSTjt2LyjSXq3DZU v6WfCG1hXtvjXLQcr5b1sLLSQtAKjUIV5gYa9LxMA/vM0ecEWNmdfSw0tAfYMG8hpRg4 h4WC9UvLvarlfxsh0j/IDjjCBPHz2wyGq8aDQK24HiPVtFua8v1UuY7ksBwZ7hWL4eBa mbQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LCddcK4tw6CGnCM2cDc7YvELzgqnmsQ+NTYYZUUQpII=; b=iDfEzgQ8W3yZdaTs3AYNw05B80o2fvU4q5WkTdoeNHGmtOU/ehG1GXnXp0P0vPnp+5 hkFnAUk4FYyUO4aLS6XITrAHF6xDnp7iUUfYXshyla6pUmwp4yWfe2/2o3fkpRDbWwCA IzA4keuK7Pr5WuWhn51W9k2PuvWi+qhwVYwCA/ZswjVW44ZQAp/pk9N3yhZZczhhX5ye hG4u5BWQgtpe4qABG87fym2G8LSrAF+VdWjmc62uqzF4inrtbDI1ZlVaaCDBU/Wllq67 1+lm6PCr4EjoDkFFmneGZQDQHuyH2HW+ynrosCPds+uvgDjDxgvLA32ux3W9I2ppn3U5 h5eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AZWZsE5I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si6787800pfu.273.2018.11.27.21.11.56; Tue, 27 Nov 2018 21:12:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AZWZsE5I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbeK1QK1 (ORCPT + 99 others); Wed, 28 Nov 2018 11:10:27 -0500 Received: from mail-pf1-f177.google.com ([209.85.210.177]:45139 "EHLO mail-pf1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbeK1QK0 (ORCPT ); Wed, 28 Nov 2018 11:10:26 -0500 Received: by mail-pf1-f177.google.com with SMTP id g62so9562029pfd.12; Tue, 27 Nov 2018 21:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LCddcK4tw6CGnCM2cDc7YvELzgqnmsQ+NTYYZUUQpII=; b=AZWZsE5IsJmq4IuVBgmccuvhhnN2/17LRTw50IGNfh11b8MIuBYnz+l5U263jqwMMQ J8g7jnldWkElD125P5KalWwMy/rfMDO+1u7wi7vA+ZvJc+xWb0HpIwnNcfNtiUI4HIzE QsvAfLhmI1D2nAY0FaUXqJqv07U29DS3QRjnYmujnB4P084SVZg+oXHe3+p7xA8E9R+O KUblWpc+ybcOreqamjpaWBrKqoj5rWm9ea5/dCltRXYv+v7nSnXdLkzyoUTW7SUkhD0d uh3StPfeYLclCqouhc4k0FxvMdE3NLCpspj6Xar9fMfRIR7p5n5qMRmgoAap0oB846gU 5FuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LCddcK4tw6CGnCM2cDc7YvELzgqnmsQ+NTYYZUUQpII=; b=o1f6KMpraGoIfLbo4Tuo2d3/Pmu550uoDkWp7LOajTw5LI8TgQFvzwiTYYOkSwQIff 9+TlQ4TNcq0uB4DXRWnGA2u7u3AcxNTkao+Tz4FKmxdSRBb/hUlsWTC7+lMDsM3AtuS3 oM5fXC0VZomg8OJweOxJ+gB29HMylpyzlAxepsUNO+G7wXdsv3hYjzdJ2/EuZb/NHUmX LABTKR+/ShBRyMSs1oxIswMxLDb+FLn7LsB8Ip5swx1DbY07CiKNVMECaZD6frS+bBvu KAn1zMNUUeIpqJF+pWvGf0Q5pDQ3IakDxwteI+rrsw9Dz3VsSeC+n2LKJAJjtcqImnvm a3Mw== X-Gm-Message-State: AA+aEWb0eJ5drHgFHVwCmUETk5mkWBwrLjzLXU3/eo01VOPwGy8/IA5Z BstMeutW7OmQY4nkFRwZYTY= X-Received: by 2002:a63:82c6:: with SMTP id w189mr32207356pgd.344.1543381806259; Tue, 27 Nov 2018 21:10:06 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::4:15df]) by smtp.gmail.com with ESMTPSA id l19sm10597187pfi.71.2018.11.27.21.10.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 21:10:05 -0800 (PST) Date: Tue, 27 Nov 2018 21:10:03 -0800 From: Alexei Starovoitov To: Aaron Conole Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Alexei Starovoitov , Daniel Borkmann , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , John Fastabend , Jesper Brouer , "David S . Miller" , Andy Gospodarek , Rony Efraim , Simon Horman , Marcelo Leitner Subject: Re: [RFC -next v0 1/3] bpf: modular maps Message-ID: <20181128051001.wcsgqx3d6c2aszp6@ast-mbp.dhcp.thefacebook.com> References: <20181125180919.13996-1-aconole@bytheb.org> <20181125180919.13996-2-aconole@bytheb.org> <20181127020608.4vucwmhrtu2cxrwu@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 27, 2018 at 09:24:05AM -0500, Aaron Conole wrote: > > 1. Introduce flowmap again, this time, basically having it close to a > copy of the hashmap. Introduce a few function calls that allow an > external module to easily manipulate all maps of that type to insert > / remove / update entries. This makes it similar to, for example, > devmap. what is a flowmap? How is this flowmap different from existing hash, lpm and lru maps? 'close to a copy of hashmap'... why hashmap is not enough for your purpose?