Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp732369imu; Tue, 27 Nov 2018 21:20:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/Up9l7Me1SKB9MO/IJAibTLRDZcYqmasRZ1rCayUuLFpHCjugVoozEZynEY91MYuI2vgUMw X-Received: by 2002:a17:902:8346:: with SMTP id z6mr35406501pln.340.1543382433040; Tue, 27 Nov 2018 21:20:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543382433; cv=none; d=google.com; s=arc-20160816; b=R9ZKc+q6ued9rNUuEq2wixb3Ljc8QOy1q21xEevOcHLq7g3nMmVS21afv0h/1QJDAY MPcMkz7hqnY7IZLb5xsxwNMRCDLpgIiSNwcdXT5Meyt+82ueo3CrYQ0AXLagWEt0DgC1 7qZkQTjRhsV1qEiVPkDMfRCjJCtsLrOLwy3pVhBap1J0QRHhQG7DKUfPDJTYgbUfqEoV kOVeRSMfuwgUsK56hQFYxjM3+7BOAsFq7Rhi6zAz5N42xb0sxeMYQMd1BHky0DCb4xys eb2G/casYCO3YbmB7vVZnHSxO0uqJRYcZTbE3UwqcVy86We9bE/SQE87aGLtgJ55o027 GPNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DW66XtOsnMcZgEqnGvQ7O+B9jezOmRSSIGJqAPBgkEU=; b=cqkMg4w+mulV56VXrghPxQJ2YnBB3BNeBxwMNXDbDr6czE5KPhW0uGD6xFrsLkTwLo 2nsIUmmAt2FptoZbPQX/MBm6c6cE7Q+iGIPDR34bJcUhO+USfhzqS8s1Fkqn3x094YKv EluKXi/7FHxvUkCqFW6XdH45KLMExiYSLI5aRiVKy6OOdgT80QIiRkqL5jtfNoAP+nO4 iQrTLunFnhduwTB6frq/yo8g76VP0M6VwLtB2DND180/Tb35t/MUV96sI7JpTcMOrP9D 6+nnMdQLDnnmbXtJviItpQFrN6bGHCLdIIt4uArdBo+itWLHrQV1n5CEY74dOv854VNI stJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si5657158pgi.89.2018.11.27.21.20.14; Tue, 27 Nov 2018 21:20:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727491AbeK1QT4 (ORCPT + 99 others); Wed, 28 Nov 2018 11:19:56 -0500 Received: from gateway36.websitewelcome.com ([192.185.197.22]:12343 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726972AbeK1QTz (ORCPT ); Wed, 28 Nov 2018 11:19:55 -0500 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 13EAC400CB2B1 for ; Tue, 27 Nov 2018 21:42:27 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id RrWwggWlskBj6RrWwgctYq; Tue, 27 Nov 2018 22:32:54 -0600 X-Authority-Reason: nr=8 Received: from [189.250.78.127] (port=58366 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gRrWv-001pRn-6u; Tue, 27 Nov 2018 22:32:53 -0600 Date: Tue, 27 Nov 2018 22:32:52 -0600 From: "Gustavo A. R. Silva" To: Hannes Reinecke Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 32/41] scsi: myrb: Mark expected switch fall-throughs Message-ID: <15cf75b544d6b2eae77ba98cd201620b44abec36.1543374820.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.78.127 X-Source-L: No X-Exim-ID: 1gRrWv-001pRn-6u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.78.127]:58366 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 230 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1465234 ("Missing break in switch") Addresses-Coverity-ID: 1465238 ("Missing break in switch") Addresses-Coverity-ID: 1465242 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/myrb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c index 0642f2d0a3bb..539ac8ce4fcd 100644 --- a/drivers/scsi/myrb.c +++ b/drivers/scsi/myrb.c @@ -1528,6 +1528,7 @@ static int myrb_ldev_queuecommand(struct Scsi_Host *shost, scmd->scsi_done(scmd); return 0; } + /* fall through */ case WRITE_6: lba = (((scmd->cmnd[1] & 0x1F) << 16) | (scmd->cmnd[2] << 8) | @@ -1544,6 +1545,7 @@ static int myrb_ldev_queuecommand(struct Scsi_Host *shost, scmd->scsi_done(scmd); return 0; } + /* fall through */ case WRITE_10: case VERIFY: /* 0x2F */ case WRITE_VERIFY: /* 0x2E */ @@ -1560,6 +1562,7 @@ static int myrb_ldev_queuecommand(struct Scsi_Host *shost, scmd->scsi_done(scmd); return 0; } + /* fall through */ case WRITE_12: case VERIFY_12: /* 0xAF */ case WRITE_VERIFY_12: /* 0xAE */ -- 2.17.1