Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Nov 2018 23:39:40 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Vivek Gautam <vivek.gautam@codeaurora.org>
Cc:     airlied@linux.ie, robdclark@gmail.com, tfiga@chromium.org,
        linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
        Jordan Crouse <jcrouse@codeaurora.org>,
        Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*
Message-ID: <20181128073940.GA13072@infradead.org>
References: <20181126213710.3084-1-vivek.gautam@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181126213710.3084-1-vivek.gautam@codeaurora.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> +		/*
> +		 * dma_sync_sg_*() flush the physical pages, so point
> +		 * sg->dma_address to the physical ones for the right behavior.
> +		 */
> +		for_each_sg(msm_obj->sgt->sgl, s, msm_obj->sgt->nents, i)
> +			sg_dma_address(s) = sg_phys(s);
> +

I'm sorry, but this is completely bogus and not acceptable.

The only place that is allowed to initialize sg_dma_address is
dma_map_sg.  If the default dma ops don't work for your setup we have
major a problem and need to fix the dma api / iommu integration instead
of hacking around it.